magento2-login-as-customer/issues/90: Static tests fix.

Author: engcom-Foxtrot

app/code/Magento/LoginAsCustomer/CustomerData/LoginAsCustomer.php

@@ -13,6 +13,8 @@
 
 /**
  * Customer data for the logged_as_customer section
+ *
+ * @SuppressWarnings(PHPMD.CookieAndSessionMisuse)
  */
 class LoginAsCustomer implements SectionSourceInterface
 {
@@ -41,6 +43,7 @@ public function __construct(
 
     /**
      * Retrieve private customer data for the logged_as_customer section
+     *
      * @return array
      */
     public function getSectionData():array
@@ -50,8 +53,8 @@ public function getSectionData():array
         }
 
         return [
-            'admin_user_id' => $this->customerSession->getLoggedAsCustomerAdmindId(),
-            'website_name' => $this->storeManager->getWebsite()->getName()
+            'adminUserId' => $this->customerSession->getLoggedAsCustomerAdmindId(),
+            'websiteName' => $this->storeManager->getWebsite()->getName()
         ];
     }
 }

app/code/Magento/LoginAsCustomer/composer.json

@@ -2,6 +2,7 @@
     "name": "magento/module-login-as-customer",
     "description": "Allow for admin to enter a customer account",
     "require": {
+        "php": "~7.1.3||~7.2.0||~7.3.0",
         "magento/framework": "*",
         "magento/module-backend": "*",
         "magento/module-checkout": "*",
@@ -19,7 +20,6 @@
         "OSL-3.0",
         "AFL-3.0"
     ],
-    "version": "2.2.1",
     "autoload": {
         "files": [ "registration.php" ],
         "psr-4": {

app/code/Magento/LoginAsCustomer/view/frontend/web/js/view/loginAsCustomer.js

@@ -23,11 +23,11 @@ define([
 
             this.customer = customerData.get('customer');
             this.loginAsCustomer = customerData.get('loggedAsCustomer');
-            this.isVisible(this.loginAsCustomer().admin_user_id);
+            this.isVisible(this.loginAsCustomer().adminUserId);
 
             this.notificationText = $.mage.__('You are connected as <strong>%1</strong> on %2')
                 .replace('%1', this.customer().fullname)
-                .replace('%2', this.loginAsCustomer().website_name);
+                .replace('%2', this.loginAsCustomer().websiteName);
         },
 
         /** @inheritdoc */