MC-21524: Schema introspection return incomplete results

avattam06 · avattam06 · commit d621ef148925 · 2019-10-25T16:20:07.000-05:00
- fixed static fixes phpcs ignore
diff --git a/lib/internal/Magento/Framework/GraphQl/Query/Fields.php b/lib/internal/Magento/Framework/GraphQl/Query/Fields.php
@@ -28,11 +28,9 @@ class Fields
      *
      * @return void
      */
-    // phpcs:ignore Generic.CodeAnalysis.EmptyStatement
     public function setQuery($query, array $variables = null)
     {
         $queryFields = [];
-
         try {
             $queryAst = \GraphQL\Language\Parser::parse(new \GraphQL\Language\Source($query ?: '', 'GraphQL'));
             \GraphQL\Language\Visitor::visit(
@@ -48,6 +46,7 @@ public function setQuery($query, array $variables = null)
             if (isset($variables)) {
                 $queryFields = array_merge($queryFields, $this->extractVariables($variables));
             }
+            // phpcs:ignore Magento2.CodeAnalysis.EmptyBlock
         } catch (\Exception $e) {
             // If a syntax error is encountered do not collect fields
         }

Original file line number	Diff line number	Diff line change
`@@ -28,11 +28,9 @@ class Fields`
`28`	`28`	`*`
`29`	`29`	`* @return void`
`30`	`30`	`*/`
`31`		`- // phpcs:ignore Generic.CodeAnalysis.EmptyStatement`
`32`	`31`	`public function setQuery($query, array $variables = null)`
`33`	`32`	`{`
`34`	`33`	`$queryFields = [];`
`35`		`-`
`36`	`34`	`try {`
`37`	`35`	`$queryAst = \GraphQL\Language\Parser::parse(new \GraphQL\Language\Source($query ?: '', 'GraphQL'));`
`38`	`36`	`\GraphQL\Language\Visitor::visit(`
`@@ -48,6 +46,7 @@ public function setQuery($query, array $variables = null)`
`48`	`46`	`if (isset($variables)) {`
`49`	`47`	`$queryFields = array_merge($queryFields, $this->extractVariables($variables));`
`50`	`48`	`}`
	`49`	`+ // phpcs:ignore Magento2.CodeAnalysis.EmptyBlock`
`51`	`50`	`} catch (\Exception $e) {`
`52`	`51`	`// If a syntax error is encountered do not collect fields`
`53`	`52`	`}`