MC-15295: Fix static tests

Author: Stepa4man

app/code/Magento/Newsletter/Model/Queue/TransportBuilder.php

@@ -23,6 +23,8 @@
 
 /**
  * Class TransportBuilder
+ *
+ * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  */
 class TransportBuilder extends \Magento\Framework\Mail\Template\TransportBuilder
 {
@@ -73,6 +75,8 @@ class TransportBuilder extends \Magento\Framework\Mail\Template\TransportBuilder
      * @param MimeMessageInterfaceFactory|null $mimeMessageInterfaceFactory
      * @param MimePartInterfaceFactory|null $mimePartInterfaceFactory
      * @param AddressConverter|null $addressConverter
+     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
         FactoryInterface $templateFactory,

lib/internal/Magento/Framework/Mail/AddressConverter.php

@@ -59,18 +59,20 @@ public function convert(string $email, ?string $name = null): Address
     public function convertMany(array $addresses): array
     {
         $addressList = [];
-        foreach ($addresses as $key=>$value) {
+        foreach ($addresses as $key => $value) {
 
             if (is_int($key) || is_numeric($key)) {
                 $addressList[] = $this->convert($value);
                 continue;
             }
 
-            if (! is_string($key)) {
-                throw new MailException(__(
-                    'Invalid key type in provided addresses array ("%s")',
-                    (is_object($key) ? get_class($key) : var_export($key, 1))
-                ));
+            if (!is_string($key)) {
+                throw new MailException(
+                    __(
+                        'Invalid key type in provided addresses array ("%1")',
+                        (is_object($key) ? get_class($key) : var_export($key, 1))
+                    )
+                );
             }
             $addressList[] = $this->convert($key, $value);
         }

lib/internal/Magento/Framework/Mail/Template/TransportBuilder.php

@@ -143,6 +143,7 @@ class TransportBuilder
      * @param MimePartInterfaceFactory|null $mimePartInterfaceFactory
      * @param addressConverter|null $addressConverter
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * @SuppressWarnings(PHPMD.ExcessiveParameterList)
      */
     public function __construct(
         FactoryInterface $templateFactory,
@@ -154,7 +155,7 @@ public function __construct(
         EmailMessageInterfaceFactory $emailMessageInterfaceFactory = null,
         MimeMessageInterfaceFactory $mimeMessageInterfaceFactory = null,
         MimePartInterfaceFactory $mimePartInterfaceFactory = null,
-        AddressConverter $addressConverter=null
+        AddressConverter $addressConverter = null
     ) {
         $this->templateFactory = $templateFactory;
         $this->objectManager = $objectManager;