MC-42795: GraphQl products query layered navigation filters return incorrect child categories list

Author: victor-v-rad

app/code/Magento/CatalogGraphQl/DataProvider/Product/LayeredNavigation/Builder/Aggregations/IncludeSubcategoriesOnly.php

@@ -23,12 +23,12 @@ class IncludeSubcategoriesOnly
     /**
      * @var string
      */
-    private $categoryBucket = 'category_bucket';
+    private const CATEGORY_BUCKET = 'category_bucket';
 
     /**
      * @var string
      */
-    private $bucketsName = 'buckets';
+    private const BUCKETS_NAME = 'buckets';
 
     /**
      * @var AggregationFactory
@@ -95,7 +95,7 @@ public function filter(AggregationInterface $aggregation, ?int $storeId): Aggreg
             return $aggregation;
         }
         $buckets = $aggregation->getBuckets();
-        $categoryBucket = $buckets[$this->categoryBucket] ?? null;
+        $categoryBucket = $buckets[self::CATEGORY_BUCKET] ?? null;
         if ($categoryBucket === null || empty($categoryBucket->getValues())) {
             return $aggregation;
         }
@@ -107,12 +107,12 @@ public function filter(AggregationInterface $aggregation, ?int $storeId): Aggreg
         );
         $categoryBucketResolved = $this->bucketFactory->create(
             [
-                'name' => $this->categoryBucket,
+                'name' => self::CATEGORY_BUCKET,
                 'values' => $bucketValuesFiltered
             ]
         );
-        $buckets[$this->categoryBucket] = $categoryBucketResolved;
-        return $this->aggregationFactory->create([$this->bucketsName => $buckets]);
+        $buckets[self::CATEGORY_BUCKET] = $categoryBucketResolved;
+        return $this->aggregationFactory->create([self::BUCKETS_NAME => $buckets]);
     }
 
     /**