Cover changes with unit test.

Author: Nazar65

app/code/Magento/Sales/Test/Unit/Model/OrderTest.php

@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+
 namespace Magento\Sales\Test\Unit\Model;
 
 use Magento\Catalog\Api\Data\ProductInterface;
@@ -17,13 +18,16 @@
 use Magento\Framework\Api\SearchCriteriaBuilder;
 use Magento\Framework\Api\SearchCriteria;
 use Magento\Sales\Api\Data\OrderItemSearchResultInterface;
+use Magento\Framework\App\Config\ScopeConfigInterface;
+use PHPUnit\Framework\MockObject\MockObject;
 
 /**
  * Test class for \Magento\Sales\Model\Order
  *
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * @SuppressWarnings(PHPMD.TooManyPublicMethods)
  * @SuppressWarnings(PHPMD.ExcessivePublicCount)
+ * @SuppressWarnings(PHPMD.TooManyFields)
  */
 class OrderTest extends \PHPUnit\Framework\TestCase
 {
@@ -102,6 +106,11 @@ class OrderTest extends \PHPUnit\Framework\TestCase
      */
     private $searchCriteriaBuilder;
 
+    /**
+     * @var MockObject|ScopeConfigInterface $scopeConfigMock
+     */
+    private $scopeConfigMock;
+
     protected function setUp()
     {
         $helper = new \Magento\Framework\TestFramework\Unit\Helper\ObjectManager($this);
@@ -125,14 +134,17 @@ protected function setUp()
             \Magento\Sales\Model\ResourceModel\Order\CollectionFactory::class,
             ['create']
         );
-        $this->item = $this->createPartialMock(\Magento\Sales\Model\ResourceModel\Order\Item::class, [
+        $this->item = $this->createPartialMock(
+            \Magento\Sales\Model\ResourceModel\Order\Item::class,
+            [
                 'isDeleted',
                 'getQtyToInvoice',
                 'getParentItemId',
                 'getQuoteItemId',
                 'getLockedDoInvoice',
                 'getProductId',
-            ]);
+            ]
+        );
         $this->salesOrderCollectionMock = $this->getMockBuilder(
             \Magento\Sales\Model\ResourceModel\Order\Collection::class
         )->disableOriginalConstructor()
@@ -168,6 +180,7 @@ protected function setUp()
             ->setMethods(['addFilter', 'create'])
             ->disableOriginalConstructor()->getMockForAbstractClass();
 
+        $this->scopeConfigMock = $this->createMock(ScopeConfigInterface::class);
         $this->order = $helper->getObject(
             \Magento\Sales\Model\Order::class,
             [
@@ -182,7 +195,8 @@ protected function setUp()
                 'localeResolver' => $this->localeResolver,
                 'timezone' => $this->timezone,
                 'itemRepository' => $this->itemRepository,
-                'searchCriteriaBuilder' => $this->searchCriteriaBuilder
+                'searchCriteriaBuilder' => $this->searchCriteriaBuilder,
+                'scopeConfig' => $this->scopeConfigMock
             ]
         );
     }
@@ -354,6 +368,51 @@ public function testCanInvoice()
         $this->assertTrue($this->order->canInvoice());
     }
 
+    /**
+     * Ensure customer name returned correctly.
+     *
+     * @dataProvider customerNameProvider
+     * @param array $expectedData
+     */
+    public function testGetCustomerName(array $expectedData)
+    {
+        $this->order->setCustomerFirstname($expectedData['first_name']);
+        $this->order->setCustomerSuffix($expectedData['customer_suffix']);
+        $this->order->setCustomerPrefix($expectedData['customer_prefix']);
+        $this->scopeConfigMock->expects($this->exactly($expectedData['invocation']))
+            ->method('isSetFlag')
+            ->willReturn(true);
+        $this->assertEquals($expectedData['expected_name'], $this->order->getCustomerName());
+    }
+
+    /**
+     * Customer name data provider
+     */
+    public function customerNameProvider()
+    {
+        return
+            [
+                [
+                    [
+                        'first_name' => null,
+                        'invocation' => 0,
+                        'expected_name' => 'Guest',
+                        'customer_suffix' => 'smith',
+                        'customer_prefix' => 'mr.'
+                    ]
+                ],
+                [
+                    [
+                        'first_name' => 'Smith',
+                        'invocation' => 1,
+                        'expected_name' => 'mr. Smith  Carl',
+                        'customer_suffix' => 'Carl',
+                        'customer_prefix' => 'mr.'
+                    ]
+                ]
+            ];
+    }
+
     /**
      * @param string $status
      *
@@ -819,9 +878,10 @@ public function testCanVoidPayment($actionFlags, $orderState)
         if ($orderState == \Magento\Sales\Model\Order::STATE_PAYMENT_REVIEW) {
             $canVoidOrder = false;
         }
-        if ($orderState == \Magento\Sales\Model\Order::STATE_HOLDED && (!isset(
-            $actionFlags[\Magento\Sales\Model\Order::ACTION_FLAG_UNHOLD]
-        ) || $actionFlags[\Magento\Sales\Model\Order::ACTION_FLAG_UNHOLD] !== false)
+        if ($orderState == \Magento\Sales\Model\Order::STATE_HOLDED &&
+            (!isset($actionFlags[\Magento\Sales\Model\Order::ACTION_FLAG_UNHOLD]) ||
+                $actionFlags[\Magento\Sales\Model\Order::ACTION_FLAG_UNHOLD] !== false
+            )
         ) {
             $canVoidOrder = false;
         }