Skip to content

Commit d44e6f1

Browse files
author
Volodymyr Kublytskyi
committed
MAGETWO-64523: Add static test on forbidden "final" keyword and eliminate it usage in code
- refactoring (moved to more semantically correct namespace)
1 parent 5e47d4a commit d44e6f1

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

dev/tests/static/framework/Magento/MessDetector/resources/rulesets/design.xml renamed to dev/tests/static/framework/Magento/CodeMessDetector/resources/rulesets/design.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
66
xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
77
<rule name="FinalImplementation"
8-
class="Magento\MessDetector\Rule\Design\FinalImplementation"
8+
class="Magento\CodeMessDetector\Rule\Design\FinalImplementation"
99
message= "The {0} {1} declared as final.">
1010
<description>
1111
<![CDATA[

dev/tests/static/framework/Magento/MessDetector/src/Rule/Design/FinalImplementation.php renamed to dev/tests/static/framework/Magento/CodeMessDetector/src/Rule/Design/FinalImplementation.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
* See COPYING.txt for license details.
55
*/
66

7-
namespace Magento\MessDetector\Rule\Design;
7+
namespace Magento\CodeMessDetector\Rule\Design;
88

99
use PHPMD\AbstractNode;
1010
use PHPMD\AbstractRule;

dev/tests/static/framework/autoload.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
$testsBaseDir . '/../integration/framework/Magento/TestFramework/',
1919
]
2020
);
21-
$autoloadWrapper->addPsr4('Magento\\MessDetector\\', $testsBaseDir . '/framework/Magento/MessDetector/src');
21+
$autoloadWrapper->addPsr4('Magento\\CodeMessDetector\\', $testsBaseDir . '/framework/Magento/CodeMessDetector/src');
2222

2323
$generatedCode = DirectoryList::getDefaultConfig()[DirectoryList::GENERATED_CODE][DirectoryList::PATH];
2424
$autoloadWrapper->addPsr4('Magento\\', $baseDir . '/' . $generatedCode . '/Magento/');

dev/tests/static/testsuite/Magento/Test/Php/_files/phpmd/ruleset.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,6 @@
4646
<rule ref="rulesets/naming.xml/BooleanGetMethodName" />
4747

4848
<!-- Magento Specific Rules -->
49-
<rule ref="Magento/MessDetector/resources/rulesets/design.xml/FinalImplementation" />
49+
<rule ref="Magento/CodeMessDetector/resources/rulesets/design.xml/FinalImplementation" />
5050

5151
</ruleset>

0 commit comments

Comments
 (0)