AC-13855: Penny rounding error in catalog rule

sumesh-GL · sumesh-GL · commit d44665b3b188 · 2025-01-31T19:31:22.000+05:30
Update decimal precision to 3 while saving price to DB
diff --git a/app/code/Magento/Directory/Model/PriceCurrency.php b/app/code/Magento/Directory/Model/PriceCurrency.php
@@ -15,6 +15,8 @@
  */
 class PriceCurrency implements \Magento\Framework\Pricing\PriceCurrencyInterface
 {
+    const PRECISION_TO_FIX_PENNY_ROUNDING_ERROR = 3;
+
     /**
      * @var \Magento\Store\Model\StoreManagerInterface
      */
@@ -152,7 +154,7 @@ protected function getStore($scope = null)
      */
     public function round($price)
     {
-        return round((float) $price, 2);
+        return round((float) $price, self::PRECISION_TO_FIX_PENNY_ROUNDING_ERROR);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,8 @@`
`15`	`15`	`*/`
`16`	`16`	`class PriceCurrency implements \Magento\Framework\Pricing\PriceCurrencyInterface`
`17`	`17`	`{`
	`18`	`+ const PRECISION_TO_FIX_PENNY_ROUNDING_ERROR = 3;`
	`19`	`+`
`18`	`20`	`/**`
`19`	`21`	`* @var \Magento\Store\Model\StoreManagerInterface`
`20`	`22`	`*/`
`@@ -152,7 +154,7 @@ protected function getStore($scope = null)`
`152`	`154`	`*/`
`153`	`155`	`public function round($price)`
`154`	`156`	`{`
`155`		`- return round((float) $price, 2);`
	`157`	`+ return round((float) $price, self::PRECISION_TO_FIX_PENNY_ROUNDING_ERROR);`
`156`	`158`	`}`
`157`	`159`
`158`	`160`	`/**`