Skip to content

Commit d4343e6

Browse files
committed
ACP2E-866: Incorrect Dashboard YTD values
1 parent 2148792 commit d4343e6

File tree

1 file changed

+4
-6
lines changed

1 file changed

+4
-6
lines changed

app/code/Magento/Reports/Test/Unit/Model/ResourceModel/Order/CollectionTest.php

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,6 @@ public function testGetDateRangeFirstPart($range, $customStart, $customEnd, $exp
295295
* @param string $customStart
296296
* @param string $customEnd
297297
* @param string $config
298-
* @param string $configVal
299298
* @param int $expectedYear
300299
* @dataProvider secondPartDateRangeDataProvider
301300
* @return void
@@ -305,7 +304,6 @@ public function testGetDateRangeSecondPart(
305304
$customStart,
306305
$customEnd,
307306
$config,
308-
$configVal,
309307
$expectedYear
310308
): void {
311309
$this->scopeConfigMock
@@ -315,7 +313,7 @@ public function testGetDateRangeSecondPart(
315313
$config,
316314
ScopeInterface::SCOPE_STORE
317315
)
318-
->willReturn($configVal);
316+
->willReturn(1);
319317

320318
$result = $this->collection->getDateRange($range, $customStart, $customEnd);
321319
$this->assertCount(3, $result);
@@ -483,9 +481,9 @@ public function secondPartDateRangeDataProvider(): array
483481
$expected2YTDYear = $expectedYear - 1;
484482

485483
return [
486-
['1m', 1, 10, 'reports/dashboard/mtd_start', '1', $expectedYear],
487-
['1y', 1, 10, 'reports/dashboard/ytd_start', '1,1', $expectedYear],
488-
['2y', 1, 10, 'reports/dashboard/ytd_start', '1,1', $expected2YTDYear]
484+
['1m', 1, 10, 'reports/dashboard/mtd_start', $expectedYear],
485+
['1y', 1, 10, 'reports/dashboard/ytd_start', $expectedYear],
486+
['2y', 1, 10, 'reports/dashboard/ytd_start', $expected2YTDYear]
489487
];
490488
}
491489

0 commit comments

Comments
 (0)