Skip to content

Commit d4317c4

Browse files
authored
Merge pull request #157 from magento-architects/ECP-202-rotation-deprecation
ECP-202: Deprecate Rotation Support in Magento
2 parents b5ff0b7 + aaa8c4d commit d4317c4

File tree

7 files changed

+13
-0
lines changed

7 files changed

+13
-0
lines changed

app/code/Magento/Catalog/Helper/Image.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,13 +45,15 @@ class Image extends AbstractHelper implements ArgumentInterface
4545
* Scheduled for rotate image
4646
*
4747
* @var bool
48+
* @deprecated unused
4849
*/
4950
protected $_scheduleRotate = false;
5051

5152
/**
5253
* Angle
5354
*
5455
* @var int
56+
* @deprecated unused
5557
*/
5658
protected $_angle;
5759

@@ -408,6 +410,7 @@ public function backgroundColor($colorRGB)
408410
*
409411
* @param int $angle
410412
* @return $this
413+
* @deprecated unused
411414
*/
412415
public function rotate($angle)
413416
{
@@ -617,6 +620,7 @@ protected function _getModel()
617620
*
618621
* @param int $angle
619622
* @return $this
623+
* @deprecated unused
620624
*/
621625
protected function setAngle($angle)
622626
{
@@ -628,6 +632,7 @@ protected function setAngle($angle)
628632
* Get Rotation Angle
629633
*
630634
* @return int
635+
* @deprecated unused
631636
*/
632637
protected function getAngle()
633638
{

app/code/Magento/Catalog/Model/Product/Image.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ class Image extends \Magento\Framework\Model\AbstractModel
101101

102102
/**
103103
* @var int
104+
* @deprecated unused
104105
*/
105106
protected $_angle;
106107

@@ -524,6 +525,7 @@ public function resize()
524525
*
525526
* @param int $angle
526527
* @return $this
528+
* @deprecated unused
527529
*/
528530
public function rotate($angle)
529531
{
@@ -539,6 +541,7 @@ public function rotate($angle)
539541
*
540542
* @param int $angle
541543
* @return $this
544+
* @deprecated unused
542545
*/
543546
public function setAngle($angle)
544547
{

lib/internal/Magento/Framework/Image.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ public function save($destination = null, $newFileName = null)
8585
* @param int $angle
8686
* @access public
8787
* @return void
88+
* @deprecated unused
8889
*/
8990
public function rotate($angle)
9091
{

lib/internal/Magento/Framework/Image/Adapter/AbstractAdapter.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ abstract public function resize($width = null, $height = null);
204204
*
205205
* @param int $angle
206206
* @return void
207+
* @deprecated unused
207208
*/
208209
abstract public function rotate($angle);
209210

lib/internal/Magento/Framework/Image/Adapter/AdapterInterface.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ public function save($destination = null, $newName = null);
113113
*
114114
* @param int $angle
115115
* @return void
116+
* @deprecated unused
116117
*/
117118
public function rotate($angle);
118119
}

lib/internal/Magento/Framework/Image/Adapter/Gd2.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -411,6 +411,7 @@ public function resize($frameWidth = null, $frameHeight = null)
411411
*
412412
* @param int $angle
413413
* @return void
414+
* @deprecated unused
414415
*/
415416
public function rotate($angle)
416417
{

lib/internal/Magento/Framework/Image/Adapter/ImageMagick.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ public function resize($frameWidth = null, $frameHeight = null)
195195
*
196196
* @param int $angle
197197
* @return void
198+
* @deprecated unused
198199
*/
199200
public function rotate($angle)
200201
{

0 commit comments

Comments
 (0)