Fixed Integration Test CreateShipmentForOrderTest

Author: anzin

app/code/Magento/Sales/Model/Order/ShipmentFactory.php

@@ -136,6 +136,12 @@ protected function prepareItems(
                 }
             } else {
                 if (isset($items[$orderItem->getId()])) {
+                    if (!is_numeric($items[$orderItem->getId()])) {
+                        throw new \Magento\Framework\Exception\LocalizedException(
+                            __('The specified qty is not valid.')
+                        );
+                    }
+
                     $qty = min($items[$orderItem->getId()], $orderItem->getQtyToShip());
                 } elseif (!count($items)) {
                     $qty = $orderItem->getQtyToShip();

dev/tests/integration/testsuite/Magento/ImportExport/Model/Export/ConsumerTest.php

@@ -94,7 +94,7 @@ public function testProcess(): void
         $data = $this->csvReader->getData($this->directory->getAbsolutePath($this->filePath));
         $this->assertCount(2, $data);
         $skuPosition = $this->getSkuPosition($data);
-        $this->assertNotFalse($skuPosition);
+        $this->assertNotNull($skuPosition);
         $this->assertEquals('simple2', $data[1][$skuPosition]);
     }
 
@@ -103,9 +103,9 @@ public function testProcess(): void
      *
      * @param array $csvFileData
      *
-     * @return bool|int
+     * @return int|null
      */
-    private function getSkuPosition(array $csvFileData)
+    private function getSkuPosition(array $csvFileData): ?int
     {
         foreach ($csvFileData as $data) {
             $skuPosition = array_search(ProductInterface::SKU, $data);
@@ -115,6 +115,6 @@ private function getSkuPosition(array $csvFileData)
             }
         }
 
-        return false;
+        return null;
     }
 }

dev/tests/integration/testsuite/Magento/Shipping/Controller/Adminhtml/Order/Shipment/Save/CreateShipmentForOrderTest.php

@@ -234,7 +234,7 @@ public function testCreateOrderShipmentWithAlphabetQty(): void
         $postData = $this->createPostData($dataToSend);
         $this->performShipmentCreationRequest($postData);
         $this->assertCreateShipmentRequestWithError(
-            "Shipment Document Validation Error(s):\nYou can't create a shipment without products.",
+            "The specified qty is not valid.",
             "admin/order_shipment/new/order_id/{$postData['order_id']}"
         );
     }