Skip to content

Commit d3af351

Browse files
author
Volodymyr Zaets
committed
Merge remote-tracking branch 'origin/MAGETWO-44422' into PR
2 parents 7573445 + 218976f commit d3af351

File tree

6 files changed

+15
-23
lines changed

6 files changed

+15
-23
lines changed

app/code/Magento/Checkout/view/frontend/web/js/sidebar.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@ define([
5353
actions: {
5454
confirm: function () {
5555
self._removeItem($(event.currentTarget));
56+
},
57+
always: function (event) {
58+
event.stopImmediatePropagation();
5659
}
5760
}
5861
});

app/code/Magento/Ui/view/base/web/js/modal/confirm.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ define([
4040
/**
4141
* Click handler.
4242
*/
43-
click: function () {
44-
this.closeModal();
43+
click: function (event) {
44+
this.closeModal(event);
4545
}
4646
}, {
4747
text: $.mage.__('OK'),
@@ -50,8 +50,8 @@ define([
5050
/**
5151
* Click handler.
5252
*/
53-
click: function () {
54-
this.closeModal(true);
53+
click: function (event) {
54+
this.closeModal(event, true);
5555
}
5656
}]
5757
},
@@ -82,15 +82,15 @@ define([
8282
/**
8383
* Close modal window.
8484
*/
85-
closeModal: function (result) {
85+
closeModal: function (event, result) {
8686
result = result || false;
8787

8888
if (result) {
89-
this.options.actions.confirm();
89+
this.options.actions.confirm(event);
9090
} else {
91-
this.options.actions.cancel();
91+
this.options.actions.cancel(event);
9292
}
93-
this.options.actions.always();
93+
this.options.actions.always(event);
9494
this.element.bind('confirmclosed', _.bind(this._remove, this));
9595

9696
return this._super();

app/code/Magento/Ui/view/base/web/js/modal/modal.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,8 @@ define([
7878
/**
7979
* Default action on button click
8080
*/
81-
click: function () {
82-
this.closeModal();
81+
click: function (event) {
82+
this.closeModal(event);
8383
}
8484
}]
8585
},

dev/tools/grunt/assets/legacy-build/shim.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
(function () {
66
'use strict';
77

8-
var globals = ['Prototype', 'Abstract', 'Try', 'Class', 'PeriodicalExecuter', 'Template', '$break', 'Enumerable', '$A', '$w', '$H', 'Hash', '$R', 'ObjectRange', 'Ajax', '$', 'Form', 'Field', '$F', 'Toggle', 'Insertion', '$continue', 'Position', 'Windows', 'Dialog', 'array', 'WindowUtilities', 'Builder', 'Effect', 'validateCreditCard', 'Validator', 'Validation', 'removeDelimiters', 'parseNumber', 'popWin', 'setLocation', 'setPLocation', 'setLanguageCode', 'decorateGeneric', 'decorateTable', 'decorateList', 'decorateDataList', 'parseSidUrl', 'formatCurrency', 'expandDetails', 'isIE', 'Varien', 'fireEvent', 'modulo', 'byteConvert', 'SessionError', 'varienLoader', 'varienLoaderHandler', 'setLoaderPosition', 'toggleSelectsUnderBlock', 'varienUpdater', 'confirmSetLocation', 'deleteConfirm', 'setElementDisable', 'toggleParentVis', 'toggleFieldsetVis', 'toggleVis', 'imagePreview', 'checkByProductPriceType', 'toggleSeveralValueElements', 'toggleValueElements', 'submitAndReloadArea', 'syncOnchangeValue', 'updateElementAtCursor', 'firebugEnabled', 'disableElement', 'enableElement', 'disableElements', 'enableElements', 'Cookie', 'Fieldset', 'Base64', 'sortNumeric', 'Element', '$$', 'Sizzle', 'Selector', 'Window'];
8+
var globals = ['Prototype', 'Abstract', 'Try', 'Class', 'PeriodicalExecuter', 'Template', '$break', 'Enumerable', '$A', '$w', '$H', 'Hash', '$R', 'ObjectRange', 'Ajax', '$', 'Form', 'Field', '$F', 'Toggle', 'Insertion', '$continue', 'Position', 'Windows', 'Dialog', 'array', 'WindowUtilities', 'Builder', 'Effect', 'validateCreditCard', 'Validator', 'Validation', 'removeDelimiters', 'parseNumber', 'popWin', 'setLocation', 'setPLocation', 'setLanguageCode', 'decorateGeneric', 'decorateTable', 'decorateList', 'decorateDataList', 'parseSidUrl', 'formatCurrency', 'expandDetails', 'isIE', 'Varien', 'fireEvent', 'modulo', 'byteConvert', 'SessionError', 'varienLoader', 'varienLoaderHandler', 'setLoaderPosition', 'toggleSelectsUnderBlock', 'varienUpdater', 'setElementDisable', 'toggleParentVis', 'toggleFieldsetVis', 'toggleVis', 'imagePreview', 'checkByProductPriceType', 'toggleSeveralValueElements', 'toggleValueElements', 'submitAndReloadArea', 'syncOnchangeValue', 'updateElementAtCursor', 'firebugEnabled', 'disableElement', 'enableElement', 'disableElements', 'enableElements', 'Cookie', 'Fieldset', 'Base64', 'sortNumeric', 'Element', '$$', 'Sizzle', 'Selector', 'Window'];
99

1010
globals.forEach(function (prop) {
1111
/* jshint evil:true */

lib/web/legacy-build.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/web/mage/adminhtml/tools.js

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,6 @@ function setLocation(url){
66
window.location.href = url;
77
}
88

9-
function confirmSetLocation(message, url){
10-
if( confirm(message) ) {
11-
setLocation(url);
12-
}
13-
return false;
14-
}
15-
16-
function deleteConfirm(message, url) {
17-
confirmSetLocation(message, url);
18-
}
19-
209
function setElementDisable(element, disable){
2110
if($(element)){
2211
$(element).disabled = disable;

0 commit comments

Comments
 (0)