Skip to content

Commit d3586b3

Browse files
author
Igor Melnikov
committed
MAGETWO-66331: Implement solution to update duplicate rows at once and add environment variable to control batch size
- refactoring integration test
1 parent 84cf488 commit d3586b3

File tree

1 file changed

+1
-9
lines changed

1 file changed

+1
-9
lines changed

dev/tests/integration/testsuite/Magento/Framework/DB/DataConverter/DataConverterTest.php

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
use Magento\Framework\DB\Select;
1111
use Magento\Framework\DB\Select\QueryModifierInterface;
1212
use Magento\Framework\DB\Select\InQueryModifier;
13-
use Magento\Framework\Serialize\Serializer\Serialize;
1413
use Magento\TestFramework\Helper\Bootstrap;
1514
use Magento\Framework\DB\Query\Generator;
1615
use Magento\Framework\DB\Query\BatchIterator;
@@ -139,14 +138,9 @@ function () use (&$iterationComplete) {
139138
*/
140139
public function testDataConvertErrorReporting()
141140
{
142-
/** @var Serialize $serializer */
143-
$serializer = $this->objectManager->create(Serialize::class);
144-
$serializedData = $serializer->serialize(['some' => 'data', 'other' => 'other data']);
145-
$serializedDataLength = strlen($serializedData);
146-
$brokenSerializedData = substr($serializedData, 0, $serializedDataLength - 6);
147141
$rows = [
148142
1 => 'N;',
149-
2 => $brokenSerializedData,
143+
2 => 'a:2:{s:3:"foo";s:3:"bar";s:3:"bar";s:',
150144
];
151145

152146
$this->adapterMock->expects($this->any())
@@ -161,8 +155,6 @@ public function testDataConvertErrorReporting()
161155
$this->fieldDataConverter->convert($this->adapterMock, 'table', 'id', 'value', $this->queryModifierMock);
162156
}
163157

164-
/**
165-
*/
166158
public function testAlreadyConvertedDataSkipped()
167159
{
168160
$rows = [

0 commit comments

Comments
 (0)