MTA-3996: Create util for troubleshooting analysis with functional test execution

rliukshyn · rliukshyn · commit d2ae761e063a · 2017-01-25T12:46:51.000+02:00
- stabilization
diff --git a/dev/tests/functional/lib/Magento/Mtf/Troubleshooting/StaticClassesGenerator.php b/dev/tests/functional/lib/Magento/Mtf/Troubleshooting/StaticClassesGenerator.php
@@ -51,7 +51,6 @@ protected function configure()
      * @param OutputInterface $output
      * @return void
      * @SuppressWarnings(PHPMD.UnusedFormalParameter)
-     * @SuppressWarnings(PHPMD.ExitExpression)
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
@@ -60,9 +59,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
             ['output' => $output]
         );
         $output->writeln("Generating static classes...");
-        passthru('php generate.php', $exitCode);
+        exec('php ' . MTF_BP . DIRECTORY_SEPARATOR . 'utils' . DIRECTORY_SEPARATOR . 'generate.php', $error, $exitCode);
         if ($exitCode) {
-            exit($exitCode);
+            $output->outputMessages(['error' => $error]);
         }
         $output->writeln('Static classes generation is finished.');
     }

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,6 @@ protected function configure()`
`51`	`51`	`* @param OutputInterface $output`
`52`	`52`	`* @return void`
`53`	`53`	`* @SuppressWarnings(PHPMD.UnusedFormalParameter)`
`54`		`- * @SuppressWarnings(PHPMD.ExitExpression)`
`55`	`54`	`*/`
`56`	`55`	`protected function execute(InputInterface $input, OutputInterface $output)`
`57`	`56`	`{`
`@@ -60,9 +59,9 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`60`	`59`	`['output' => $output]`
`61`	`60`	`);`
`62`	`61`	`$output->writeln("Generating static classes...");`
`63`		`- passthru('php generate.php', $exitCode);`
	`62`	`+ exec('php ' . MTF_BP . DIRECTORY_SEPARATOR . 'utils' . DIRECTORY_SEPARATOR . 'generate.php', $error, $exitCode);`
`64`	`63`	`if ($exitCode) {`
`65`		`- exit($exitCode);`
	`64`	`+ $output->outputMessages(['error' => $error]);`
`66`	`65`	`}`
`67`	`66`	`$output->writeln('Static classes generation is finished.');`
`68`	`67`	`}`