Skip to content

Commit d27a28c

Browse files
🔃 [Magento Community Engineering] Community Contributions - 2.3-develop expedited
Accepted Community Pull Requests: - #23200: MFTF: use LogoutActionGroup instead of `amOnPage` /auth/logout (by @lbajsarowicz)
2 parents 3cbe632 + 401d6ef commit d27a28c

File tree

53 files changed

+69
-78
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

53 files changed

+69
-78
lines changed

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateCategoryTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
<group value="category"/>
2020
</annotations>
2121
<after>
22-
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>
22+
<actionGroup ref="logout" stepKey="adminLogout"/>
2323
</after>
2424

2525
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin1"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateProductDuplicateUrlkeyTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
</createData>
2424
</before>
2525
<after>
26-
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>
26+
<actionGroup ref="logout" stepKey="adminLogout"/>
2727
<deleteData createDataKey="simpleProduct" stepKey="deleteProduct"/>
2828
</after>
2929

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateSimpleProductTest.xml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
<createData entity="_defaultCategory" stepKey="createPreReqCategory"/>
2323
</before>
2424
<after>
25-
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>
2625
<deleteData createDataKey="createPreReqCategory" stepKey="deletePreReqCategory"/>
2726
</after>
2827

app/code/Magento/Catalog/Test/Mftf/Test/AdminCreateSimpleProductWithUnicodeTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<createData entity="_defaultCategory" stepKey="createPreReqCategory"/>
2323
</before>
2424
<after>
25-
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>
25+
<actionGroup ref="logout" stepKey="adminLogout"/>
2626
<deleteData createDataKey="createPreReqCategory" stepKey="deletePreReqCategory"/>
2727
</after>
2828

app/code/Magento/Catalog/Test/Mftf/Test/AdminMultipleWebsitesUseDefaultValuesTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<actionGroup ref="AdminDeleteWebsiteActionGroup" stepKey="deleteSecondWebsite">
2323
<argument name="websiteName" value="Second Website"/>
2424
</actionGroup>
25-
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>
25+
<actionGroup ref="logout" stepKey="adminLogout"/>
2626
</after>
2727
<actionGroup ref="LoginActionGroup" stepKey="loginAsAdmin"/>
2828
<actionGroup ref="AdminCreateWebsiteActionGroup" stepKey="createAdditionalWebsite">

app/code/Magento/Catalog/Test/Mftf/Test/AdminRequiredFieldsHaveRequiredFieldIndicatorTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
<group value="Catalog"/>
1919
</annotations>
2020
<after>
21-
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>
21+
<actionGroup ref="logout" stepKey="adminLogout"/>
2222
</after>
2323

2424
<actionGroup ref="LoginAsAdmin" stepKey="loginAsAdmin1"/>

app/code/Magento/Catalog/Test/Mftf/Test/AdminSimpleProductImagesTest.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
<deleteData createDataKey="category" stepKey="deletePreReqCategory"/>
3535
<deleteData createDataKey="firstProduct" stepKey="deleteFirstProduct"/>
3636
<deleteData createDataKey="secondProduct" stepKey="deleteSecondProduct"/>
37-
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>
37+
<actionGroup ref="logout" stepKey="adminLogout"/>
3838
</after>
3939

4040
<!-- Go to the first product edit page -->
@@ -186,7 +186,7 @@
186186
<after>
187187
<deleteData createDataKey="category" stepKey="deletePreReqCategory"/>
188188
<deleteData createDataKey="product" stepKey="deleteProduct"/>
189-
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>
189+
<actionGroup ref="logout" stepKey="adminLogout"/>
190190
</after>
191191

192192
<!-- Go to the product edit page -->

app/code/Magento/Catalog/Test/Mftf/Test/AdminUpdateCategoryStoreUrlKeyTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<actionGroup ref="DeleteCategory" stepKey="deleteCategory">
2323
<argument name="categoryEntity" value="_defaultCategory"/>
2424
</actionGroup>
25-
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>
25+
<actionGroup ref="logout" stepKey="adminLogout"/>
2626
</after>
2727

2828
<!-- Create category, change store view to default -->

app/code/Magento/Catalog/Test/Mftf/Test/DeleteCategoriesTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
<createData entity="NewRootCategory" stepKey="createNewRootCategoryA"/>
3737
</before>
3838
<after>
39-
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>
39+
<actionGroup ref="logout" stepKey="adminLogout"/>
4040
<deleteData createDataKey="createProduct1" stepKey="deleteProduct1"/>
4141
<deleteData createDataKey="createProduct2" stepKey="deleteProduct2"/>
4242
<deleteData createDataKey="createProduct3" stepKey="deleteProduct3"/>

app/code/Magento/Catalog/Test/Mftf/Test/SaveProductWithCustomOptionsSecondWebsiteTest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
<actionGroup ref="AdminDeleteWebsiteActionGroup" stepKey="deleteTestWebsite">
5454
<argument name="websiteName" value="Second Website"/>
5555
</actionGroup>
56-
<amOnPage url="admin/admin/auth/logout/" stepKey="amOnLogoutPage"/>
56+
<actionGroup ref="logout" stepKey="adminLogout"/>
5757
</after>
5858

5959
<actionGroup ref="EnableWebUrlOptions" stepKey="addStoreCodeToUrls"/>

0 commit comments

Comments
 (0)