Skip to content

Commit d255311

Browse files
committed
AC2093:Fixed static test
1 parent 6152fd0 commit d255311

File tree

3 files changed

+17
-18
lines changed

3 files changed

+17
-18
lines changed

app/code/Magento/Paypal/Block/Express/Review.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -307,6 +307,11 @@ protected function _beforeToHtml()
307307
return parent::_beforeToHtml();
308308
}
309309

310+
/**
311+
* Return paypal funding source
312+
*
313+
* @return string|null
314+
*/
310315
public function getPaypalFundingSource()
311316
{
312317
if ($this->_quote->getPayment()->getPaypalFundingSource()) {

app/code/Magento/Paypal/Controller/Express/OnAuthorization.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,19 @@
3333
class OnAuthorization extends AbstractExpress implements HttpPostActionInterface
3434
{
3535
/**
36+
* @var PayPalConfig
3637
* @inheritdoc
3738
*/
3839
protected $_configType = PayPalConfig::class;
3940

4041
/**
42+
* @var PayPalConfig
4143
* @inheritdoc
4244
*/
4345
protected $_configMethod = PayPalConfig::METHOD_WPP_EXPRESS;
4446

4547
/**
48+
* @var PayPalCheckout
4649
* @inheritdoc
4750
*/
4851
protected $_checkoutType = PayPalCheckout::class;
@@ -53,8 +56,6 @@ class OnAuthorization extends AbstractExpress implements HttpPostActionInterface
5356
private $cartRepository;
5457

5558
/**
56-
* Url Builder
57-
*
5859
* @var UrlInterface
5960
*/
6061
private $urlBuilder;

app/code/Magento/Paypal/Model/Express/Checkout.php

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -30,25 +30,25 @@ class Checkout
3030
*
3131
* @var string
3232
*/
33-
const PAL_CACHE_ID = 'paypal_express_checkout_pal';
33+
private const PAL_CACHE_ID = 'paypal_express_checkout_pal';
3434

3535
/**
3636
* Keys for passthrough variables in sales/quote_payment and sales/order_payment
3737
* Uses additional_information as storage
3838
*/
39-
const PAYMENT_INFO_TRANSPORT_TOKEN = 'paypal_express_checkout_token';
40-
const PAYMENT_INFO_TRANSPORT_SHIPPING_OVERRIDDEN = 'paypal_express_checkout_shipping_overridden';
41-
const PAYMENT_INFO_TRANSPORT_SHIPPING_METHOD = 'paypal_express_checkout_shipping_method';
42-
const PAYMENT_INFO_TRANSPORT_PAYER_ID = 'paypal_express_checkout_payer_id';
43-
const PAYMENT_INFO_TRANSPORT_REDIRECT = 'paypal_express_checkout_redirect_required';
44-
const PAYMENT_INFO_TRANSPORT_BILLING_AGREEMENT = 'paypal_ec_create_ba';
39+
public const PAYMENT_INFO_TRANSPORT_TOKEN = 'paypal_express_checkout_token';
40+
public const PAYMENT_INFO_TRANSPORT_SHIPPING_OVERRIDDEN = 'paypal_express_checkout_shipping_overridden';
41+
public const PAYMENT_INFO_TRANSPORT_SHIPPING_METHOD = 'paypal_express_checkout_shipping_method';
42+
public const PAYMENT_INFO_TRANSPORT_PAYER_ID = 'paypal_express_checkout_payer_id';
43+
public const PAYMENT_INFO_TRANSPORT_REDIRECT = 'paypal_express_checkout_redirect_required';
44+
public const PAYMENT_INFO_TRANSPORT_BILLING_AGREEMENT = 'paypal_ec_create_ba';
4545

4646
/**
4747
* Flag which says that was used PayPal Express Checkout button for checkout
4848
* Uses additional_information as storage
4949
* @var string
5050
*/
51-
const PAYMENT_INFO_BUTTON = 'button';
51+
public const PAYMENT_INFO_BUTTON = 'button';
5252

5353
/**
5454
* @var \Magento\Quote\Model\Quote
@@ -131,8 +131,6 @@ class Checkout
131131
protected $_isBml = false;
132132

133133
/**
134-
* Customer ID
135-
*
136134
* @var int
137135
*/
138136
protected $_customerId;
@@ -145,8 +143,6 @@ class Checkout
145143
protected $_billingAgreement;
146144

147145
/**
148-
* Order
149-
*
150146
* @var \Magento\Sales\Model\Order
151147
*/
152148
protected $_order;
@@ -157,15 +153,11 @@ class Checkout
157153
protected $_configCacheType;
158154

159155
/**
160-
* Checkout data
161-
*
162156
* @var \Magento\Checkout\Helper\Data
163157
*/
164158
protected $_checkoutData;
165159

166160
/**
167-
* Tax data
168-
*
169161
* @var \Magento\Tax\Helper\Data
170162
*/
171163
protected $_taxData;
@@ -610,6 +602,7 @@ public function canSkipOrderReviewStep()
610602
*
611603
* @param string $token
612604
* @param string|null $payerIdentifier
605+
* @param string|null $fundingSource
613606
* @return void
614607
* @SuppressWarnings(PHPMD.CyclomaticComplexity)
615608
* @SuppressWarnings(PHPMD.NPathComplexity)

0 commit comments

Comments
 (0)