MTA-3253: Customer: Extend update customer group test

Author: rsavchuk

dev/tests/functional/tests/app/Magento/Customer/Test/Block/Adminhtml/Group/Edit/Form.php

@@ -6,19 +6,29 @@
 
 namespace Magento\Customer\Test\Block\Adminhtml\Group\Edit;
 
+use Magento\Mtf\Client\Locator;
+
 /**
  * Customer group edit form.
  */
 class Form extends \Magento\Mtf\Block\Form
 {
     /**
-     *
+     * Check if field exists and is disabled.
      *
      * @param string $field
      * @return bool
+     * @throws \Exception
      */
     public function isFieldDisabled($field)
     {
-        return $this->_rootElement->find($this->mapping[$field]['selector'])->isDisabled();
+        if (!isset($this->mapping[$field])) {
+            throw new \Exception("Cannot find field $field. Check for field mapping in " . self::class);
+        }
+        $disabledField = $this->mapping[$field]['selector'];
+        $strategy = isset($this->mapping[$field]['strategy'])
+            ? $this->mapping[$field]['strategy']
+            : Locator::SELECTOR_CSS;
+        return $this->_rootElement->find($disabledField, $strategy)->isDisabled();
     }
 }

dev/tests/functional/tests/app/Magento/Customer/Test/Constraint/AssertGroupNotAvailableInField.php renamed to dev/tests/functional/tests/app/Magento/Customer/Test/Constraint/AssertCustomerGroupFieldDisabled.php

@@ -8,30 +8,28 @@
 
 use Magento\Customer\Test\Fixture\CustomerGroup;
 use Magento\Mtf\Constraint\AbstractConstraint;
-use Magento\Customer\Test\Page\Adminhtml\CustomerGroupIndex;
+use Magento\Customer\Test\Page\Adminhtml\CustomerGroupEdit;
 
 /**
  * Assert that group field is not available.
  */
-class AssertGroupNotAvailableInField extends AbstractConstraint
+class AssertCustomerGroupFieldDisabled extends AbstractConstraint
 {
     /**
      * Assert that customer group field is not available.
      *
-     * @param CustomerGroupIndex $customerGroupIndex
-     * @param CustomerGroup $customerGroup
+     * @param CustomerGroupEdit $customerGroupEdit
      * @param array $disabledFields
      * @return void
      */
     public function processAssert(
-        CustomerGroupIndex $customerGroupIndex,
-        CustomerGroup $customerGroup,
+        CustomerGroupEdit $customerGroupEdit,
         array $disabledFields
     ) {
         foreach ($disabledFields as $field) {
             \PHPUnit_Framework_Assert::assertTrue(
-                $customerGroupIndex->getPageMainForm()->isFieldDisabled($field),
-                "Field for group {$customerGroup->getCustomerGroupCode()} is not disabled."
+                $customerGroupEdit->getPageMainForm()->isFieldDisabled($field),
+                "Field $field is not disabled."
             );
         }
     }

dev/tests/functional/tests/app/Magento/Customer/Test/Page/Adminhtml/CustomerGroupEdit.xml

@@ -0,0 +1,15 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+/**
+ * Copyright © 2016 Magento. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+ -->
+<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../../vendor/magento/mtf/etc/pages.xsd">
+    <page name="CustomerGroupEdit" area="Adminhtml" mca="customer/group/edit" module="Magento_Customer">
+        <block name="pageMainActions" class="Magento\Backend\Test\Block\FormPageActions" locator=".page-main-actions" strategy="css selector" />
+        <block name="pageMainForm" class="Magento\Customer\Test\Block\Adminhtml\Group\Edit\Form" locator="[id='page:main-container']" strategy="css selector" />
+        <block name="messagesBlock" class="Magento\Backend\Test\Block\Messages" locator="#messages" strategy="css selector" />
+        <block name="modalBlock" class="Magento\Ui\Test\Block\Adminhtml\Modal" locator="._show[data-role=modal]" strategy="css selector" />
+    </page>
+</config>

dev/tests/functional/tests/app/Magento/Customer/Test/Page/Adminhtml/CustomerGroupIndex.xml

@@ -10,6 +10,5 @@
     <block name="messagesBlock" class="Magento\Backend\Test\Block\Messages" locator="#messages .messages" strategy="css selector"/>
     <block name="gridPageActions" class="Magento\Backend\Test\Block\GridPageActions" locator=".page-main-actions" strategy="css selector"/>
     <block name="customerGroupGrid" class="Magento\Customer\Test\Block\Adminhtml\Group\CustomerGroupGrid" locator="#customerGroupGrid" strategy="css selector"/>
-    <block name="pageMainForm" class="Magento\Customer\Test\Block\Adminhtml\Group\Edit\Form" locator="[id='page:main-container']" strategy="css selector"/>
   </page>
 </config>

dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/GroupNotAvailableInFieldTest.php renamed to dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/VerifyDisabledCustomerGroupFieldTest.php

@@ -8,73 +8,55 @@
 
 use Magento\Customer\Test\Fixture\CustomerGroup;
 use Magento\Customer\Test\Page\Adminhtml\CustomerGroupIndex;
-use Magento\Customer\Test\Page\Adminhtml\CustomerGroupNew;
 use Magento\Mtf\TestCase\Injectable;
 
 /**
- * Test Creation for Update Customer Group Entity
- *
- * Test Flow:
- * Preconditions:
- * 1. Customer Group is created
  * Steps:
- * 1. Log in to backend as admin user
- * 2. Navigate to Stores > Other Settings > Customer Groups
- * 3. Select Customer Group from grid
- * 4. Perform all assertions
+ * 1. Login to backend as admin user.
+ * 2. Navigate to Stores > Other Settings > Customer Groups.
+ * 3. Select system Customer Group specified in data set from grid.
+ * 4. Perform all assertions.
  *
  * @group Customer_Groups_(CS)
- * @ZephyrId
+ * @ZephyrId MAGETWO-52481
  */
-class GroupNotAvailableInFieldTest extends Injectable
+class VerifyDisabledCustomerGroupFieldTest extends Injectable
 {
     /* tags */
     const MVP = 'yes';
     const DOMAIN = 'CS';
     /* end tags */
 
     /**
-     * Page CustomerGroupIndex
+     * Page CustomerGroupIndex.
      *
      * @var CustomerGroupIndex
      */
     protected $customerGroupIndex;
 
     /**
-     * Page CustomerGroupNew
-     *
-     * @var CustomerGroupNew
-     */
-    protected $customerGroupNew;
-
-    /**
-     * Injection data
+     * Injection data.
      *
      * @param CustomerGroupIndex $customerGroupIndex
-     * @param CustomerGroupNew $customerGroupNew
      * @return void
      */
-    public function __inject(
-        CustomerGroupIndex $customerGroupIndex,
-        CustomerGroupNew $customerGroupNew
-    ) {
+    public function __inject(CustomerGroupIndex $customerGroupIndex)
+    {
         $this->customerGroupIndex = $customerGroupIndex;
-        $this->customerGroupNew = $customerGroupNew;
     }
 
     /**
-     * Check unavailable field in Customer Group
+     * Check unavailable field in Customer Group.
      *
      * @param CustomerGroup $customerGroup
      * @return void
      */
-    public function test(
-        CustomerGroup $customerGroup
-    ) {
+    public function test(CustomerGroup $customerGroup)
+    {
         $filter = ['code' => $customerGroup->getCustomerGroupCode()];
 
         // Steps
         $this->customerGroupIndex->open();
         $this->customerGroupIndex->getCustomerGroupGrid()->searchAndOpen($filter);
     }
-}
+}

dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/GroupNotAvailableInFieldTest.xml renamed to dev/tests/functional/tests/app/Magento/Customer/Test/TestCase/VerifyDisabledCustomerGroupFieldTest.xml

@@ -6,13 +6,13 @@
  */
  -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../../../../../../vendor/magento/mtf/etc/variations.xsd">
-    <testCase name="Magento\Customer\Test\TestCase\GroupNotAvailableInFieldTest" summary="Group not available">
-        <variation name="GroupNotAvailableInFieldTestVariation1">
+    <testCase name="Magento\Customer\Test\TestCase\VerifyDisabledCustomerGroupFieldTest" summary="Check that field is disabled in system Customer Group" ticketId="MAGETWO-52481">
+        <variation name="VerifyDisabledCustomerGroupField1" summary="Checks that customer_group_code field is disabled in NOT LOGGED IN Customer Group">
             <data name="customerGroup/dataset" xsi:type="string">NOT_LOGGED_IN</data>
             <data name="disabledFields" xsi:type="array">
                 <item name="0" xsi:type="string">customer_group_code</item>
             </data>
-            <constraint name="Magento\Customer\Test\Constraint\AssertGroupNotAvailableInField" />
+            <constraint name="Magento\Customer\Test\Constraint\AssertCustomerGroupFieldDisabled" />
         </variation>
     </testCase>
 </config>