Skip to content

Commit d1fbaa9

Browse files
committed
Static tests issues fixed
1 parent 4b15968 commit d1fbaa9

File tree

10 files changed

+19
-36
lines changed

10 files changed

+19
-36
lines changed

app/code/Magento/Backend/Block/Widget/Form/Renderer/Fieldset.php

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@ class Fieldset extends \Magento\Backend\Block\Template implements RendererInterf
2929
protected $_template = 'Magento_Backend::widget/form/renderer/fieldset.phtml';
3030

3131
/**
32+
* Get element
33+
*
3234
* @return AbstractElement
3335
*/
3436
public function getElement()
@@ -37,6 +39,8 @@ public function getElement()
3739
}
3840

3941
/**
42+
* Render the element
43+
*
4044
* @param AbstractElement $element
4145
* @return string
4246
*/

app/code/Magento/CatalogRule/Model/ResourceModel/Rule/Collection.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,12 +159,12 @@ public function addCustomerGroupFilter($customerGroupId)
159159
*
160160
* @return array
161161
* @deprecated 100.1.0
162-
* phpstan:ignore
163162
*/
164163
private function getAssociatedEntitiesMap()
165164
{
166165
if (!$this->_associatedEntitiesMap) {
167166
$this->_associatedEntitiesMap = \Magento\Framework\App\ObjectManager::getInstance()
167+
// phpstan:ignore
168168
->get(\Magento\CatalogRule\Model\ResourceModel\Rule\AssociatedEntityMap::class)
169169
->getData();
170170
}

app/code/Magento/Integration/Model/Config.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,8 +32,6 @@ class Config
3232
protected $_configReader;
3333

3434
/**
35-
* Array of integrations
36-
*
3735
* @var array
3836
*/
3937
protected $_integrations;

app/code/Magento/Payment/Model/Cart.php

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -38,34 +38,30 @@ class Cart
3838
protected $_eventManager;
3939

4040
/**
41-
* Amounts
42-
*
4341
* @var array
4442
*/
4543
protected $_amounts;
4644

4745
/**
48-
* Custom items list
49-
*
5046
* @var array
5147
*/
5248
protected $_customItems = [];
5349

5450
/**
55-
* Items imported from sales model
56-
*
5751
* @var array
5852
*/
5953
protected $_salesModelItems = [];
6054

6155
/**
56+
* @phpcs:ignore
6257
* Flags that indicates whether discount, shopping and taxes should be transferred as cart item
6358
*
6459
* @var array
6560
*/
6661
protected $_transferFlags = [];
6762

6863
/**
64+
* @phpcs:ignore
6965
* Flags which indicates whether items data is outdated and has to be recollected
7066
*
7167
* @var bool

app/code/Magento/Payment/Model/Method/AbstractMethod.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ abstract class AbstractMethod extends \Magento\Framework\Model\AbstractExtensibl
142142
protected $_canCancelInvoice = false;
143143

144144
/**
145+
* @phpcs:ignore
145146
* Fields that should be replaced in debug with '***'
146147
*
147148
* @var array

app/code/Magento/Shipping/Model/Carrier/AbstractCarrier.php

Lines changed: 3 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -21,43 +21,31 @@ abstract class AbstractCarrier extends \Magento\Framework\DataObject implements
2121
const DEBUG_KEYS_MASK = '****';
2222

2323
/**
24-
* Carrier's code
25-
*
2624
* @var string
2725
*/
2826
protected $_code;
2927

3028
/**
31-
* Rates result
32-
*
3329
* @var array|null
3430
*/
3531
protected $_rates;
3632

3733
/**
38-
* Number of boxes in package
39-
*
4034
* @var int
4135
*/
4236
protected $_numBoxes = 1;
4337

4438
/**
45-
* Free Method config path
46-
*
4739
* @var string
4840
*/
4941
protected $_freeMethod = 'free_method';
5042

5143
/**
52-
* Whether this carrier has fixed rates calculation
53-
*
5444
* @var bool
5545
*/
5646
protected $_isFixed = false;
5747

5848
/**
59-
* Container types that could be customized
60-
*
6149
* @var string[]
6250
*/
6351
protected $_customizableContainerTypes = [];
@@ -441,7 +429,7 @@ protected function _updateFreeMethodQuote($request)
441429
return;
442430
}
443431
$freeRateId = false;
444-
432+
// phpstan:ignore
445433
if (is_object($this->_result)) {
446434
foreach ($this->_result->getAllRates() as $i => $item) {
447435
if ($item->getMethod() == $freeMethod) {
@@ -456,8 +444,10 @@ protected function _updateFreeMethodQuote($request)
456444
}
457445
$price = null;
458446
if ($request->getFreeMethodWeight() > 0) {
447+
// phpstan:ignore
459448
$this->_setFreeMethodRequest($freeMethod);
460449

450+
// phpstan:ignore
461451
$result = $this->_getQuotes();
462452
if ($result && ($rates = $result->getAllRates()) && count($rates) > 0) {
463453
if (count($rates) == 1 && $rates[0] instanceof \Magento\Quote\Model\Quote\Address\RateResult\Method) {

app/code/Magento/Shipping/Model/Carrier/AbstractCarrierOnline.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,6 @@ abstract class AbstractCarrierOnline extends AbstractCarrier
103103
protected $_rawRequest = null;
104104

105105
/**
106-
* The security scanner XML document
107-
*
108106
* @var Security
109107
*/
110108
protected $xmlSecurity;

lib/internal/Magento/Framework/Api/ImageProcessor.php

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public function __construct(
8181
}
8282

8383
/**
84-
* {@inheritdoc}
84+
* @inheritdoc
8585
*/
8686
public function save(
8787
CustomAttributesDataInterface $dataObjectWithCustomAttributes,
@@ -132,7 +132,7 @@ public function save(
132132
}
133133

134134
/**
135-
* {@inheritdoc}
135+
* @inheritdoc
136136
*/
137137
public function processImageContent($entityType, $imageContent)
138138
{
@@ -167,6 +167,8 @@ public function processImageContent($entityType, $imageContent)
167167
}
168168

169169
/**
170+
* Get mime type extension
171+
*
170172
* @param string $mimeType
171173
* @return string
172174
*/
@@ -176,6 +178,8 @@ protected function getMimeTypeExtension($mimeType)
176178
}
177179

178180
/**
181+
* Get file name
182+
*
179183
* @param ImageContentInterface $imageContent
180184
* @return string
181185
* @throws \Magento\Framework\Exception\LocalizedException

lib/internal/Magento/Framework/Api/ImageProcessorInterface.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@
1818
interface ImageProcessorInterface
1919
{
2020
/**
21-
* Process Data objects with image type custom attributes and update the custom attribute values with saved image
22-
* paths
21+
* Process Data objects with image type custom attributes and update custom attribute values with saved image paths
2322
*
2423
* @param CustomAttributesDataInterface $dataObjectWithCustomAttributes
2524
* @param string $entityType entity type

lib/internal/Magento/Framework/Model/ResourceModel/Db/AbstractDb.php

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,22 +32,19 @@ abstract class AbstractDb extends AbstractResource
3232
protected $_resources;
3333

3434
/**
35+
* @phpcs:ignore
3536
* Prefix for resources that will be used in this resource model
3637
*
3738
* @var string
3839
*/
3940
protected $connectionName = \Magento\Framework\App\ResourceConnection::DEFAULT_CONNECTION;
4041

4142
/**
42-
* Connections cache for this resource model
43-
*
4443
* @var array
4544
*/
4645
protected $_connections = [];
4746

4847
/**
49-
* Resource model name that contains entities (names of tables)
50-
*
5148
* @var string
5249
*/
5350
protected $_resourceModel;
@@ -73,15 +70,11 @@ abstract class AbstractDb extends AbstractResource
7370
protected $_isPkAutoIncrement = true;
7471

7572
/**
76-
* Use is object new method for save of object
77-
*
7873
* @var bool
7974
*/
8075
protected $_useIsObjectNew = false;
8176

8277
/**
83-
* Fields of main table
84-
*
8578
* @var array
8679
*/
8780
protected $_mainTableFields;

0 commit comments

Comments
 (0)