Improve code, a bit

elfeffe · web-flow · commit d16dd4cacae8 · 2019-09-21T14:34:53.000+02:00
diff --git a/app/code/Magento/ConfigurableProduct/Model/Product/Type/VariationMatrix.php b/app/code/Magento/ConfigurableProduct/Model/Product/Type/VariationMatrix.php
@@ -40,7 +40,7 @@ public function getVariations($usedProductAttributes)
             for ($attributeIndex = $attributesCount; $attributeIndex--;) {
                 $currentAttribute = $variationalAttributes[$attributeIndex];
                 $currentVariationValue = $currentVariation[$attributeIndex];
-                    if(isset($currentAttribute['id']) && $currentAttribute['id']) {
+                    if(!empty($currentAttribute['id'])) {
                         $filledVariation[$currentAttribute['id']] = $currentAttribute['values'][$currentVariationValue]; 
                     }
             }

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ public function getVariations($usedProductAttributes)`
`40`	`40`	`for ($attributeIndex = $attributesCount; $attributeIndex--;) {`
`41`	`41`	`$currentAttribute = $variationalAttributes[$attributeIndex];`
`42`	`42`	`$currentVariationValue = $currentVariation[$attributeIndex];`
`43`		`- if(isset($currentAttribute['id']) && $currentAttribute['id']) {`
	`43`	`+ if(!empty($currentAttribute['id'])) {`
`44`	`44`	`$filledVariation[$currentAttribute['id']] = $currentAttribute['values'][$currentVariationValue];`
`45`	`45`	`}`
`46`	`46`	`}`