Skip to content

Commit d1133e4

Browse files
author
Oleksandr Gorkun
committed
MC-34764: Fix performance degradation cause by CSP
1 parent de679c7 commit d1133e4

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

app/code/Magento/Catalog/view/adminhtml/templates/catalog/product/composite/configure.phtml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323
<div id="product_composite_configure_form_fields" class="content product-composite-configure-inner"></div>
2424
<div id="product_composite_configure_form_additional" class="product_composite_configure_form_additional">
2525
</div>
26-
<div id="product_composite_configure_form_confirmed" class="product_composite_configure_form_confirmed"></div>
26+
<div id="product_composite_configure_form_confirmed" class="product_composite_configure_form_confirmed">
27+
</div>
2728
</div>
2829
<input type="hidden" name="as_js_varname" value="iFrameResponse" />
2930
<input type="hidden" name="form_key" value="<?= $block->escapeHtmlAttr($block->getFormKey()) ?>" />
@@ -44,11 +45,11 @@
4445
prodCompConfIframe.style.position = "absolute";
4546
prodCompConfIframe.style.top = "-1000px";
4647
prodCompConfIframe.style.left = "-1000px";
47-
document.querySelector(".product_composite_configure_messages:last-of-type").style.display = "none";
48-
document.querySelector(".product_composite_configure_form_additional:last-of-type").style.display = "none";
49-
document.querySelector(".product_composite_configure_form_confirmed:last-of-type").style.display = "none";
50-
document.querySelector(".product_composite_configure_confirmed:last-of-type").style.display = "none";
51-
document.querySelector(".product-configure-popup:last-of-type").style.display = "none";
48+
document.querySelectorAll(".product_composite_configure_messages").forEach((e) => e.style.display = "none");
49+
document.querySelectorAll(".product_composite_configure_form_additional").forEach((e) => e.style.display = "none");
50+
document.querySelectorAll(".product_composite_configure_form_confirmed").forEach((e) => e.style.display = "none");
51+
document.querySelectorAll(".product_composite_configure_confirmed").forEach((e) => e.style.display = "none");
52+
document.querySelectorAll(".product-configure-popup").forEach((e) => e.style.display = "none");
5253
5354
require([
5455
"jquery",

app/code/Magento/Catalog/view/frontend/templates/product/image_with_borders.phtml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ $padding = $block->getRatio() * 100;
4141
<?php
4242
$script = <<<SCRIPT
4343
document.querySelector('#product-image-container-{$block->getProductId()}').style.width = '{$width}px';
44-
document.querySelector('#product-image-container-{$block->getProductId()} span.product-image-wrapper').style.paddingBottom = '{$padding}%'
44+
document.querySelector('#product-image-container-{$block->getProductId()} span.product-image-wrapper')
45+
.style.paddingBottom = '{$padding}%'
4546
SCRIPT;
46-
echo /* @noEscape */$secureRenderer->renderTag('script', ['type' => 'text/javascript'], $script, false);
4747
?>
48+
<?= /* @noEscape */ $secureRenderer->renderTag('script', ['type' => 'text/javascript'], $script, false); ?>

app/code/Magento/Theme/view/frontend/templates/js/cookie_status.phtml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
</div>
1313
<?php
1414
$script = 'document.querySelector("#cookie-status").style.display = "none";';
15-
echo /* @noEscape */ $secureRenderer->renderTag('script', ['type' => 'text/javascript'], $script, false);
1615
?>
16+
<?= /* @noEscape */ $secureRenderer->renderTag('script', ['type' => 'text/javascript'], $script, false); ?>
1717

1818
<script type="text/x-magento-init">
1919
{

0 commit comments

Comments
 (0)