MAGETWO-99592: Discounts of products disappear on storefront after drag & drop via Visual Merchandiser in category

Author: dhorytskyi

app/code/Magento/CatalogRule/Model/Indexer/IndexBuilder.php

@@ -16,6 +16,8 @@
 use Magento\CatalogRule\Model\Indexer\IndexerTableSwapperInterface as TableSwapper;
 
 /**
+ * Catalog rule index builder
+ *
  * @api
  * @SuppressWarnings(PHPMD.CouplingBetweenObjects)
  * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
@@ -538,7 +540,7 @@ protected function deleteOldData()
      * Calculate rule product price
      *
      * @param array $ruleData
-     * @param null $productData
+     * @param array $productData
      * @return float
      * @deprecated 100.2.0
      * @see ProductPriceCalculator::calculate

app/code/Magento/CatalogRule/Model/Rule.php

@@ -432,7 +432,9 @@ protected function _getWebsitesMap()
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @param \Magento\Framework\DataObject $dataObject
+     * @return bool|string[]
      */
     public function validateData(DataObject $dataObject)
     {
@@ -453,7 +455,6 @@ public function validateData(DataObject $dataObject)
      *
      * @param string $action
      * @param string|int|float $discount
-     *
      * @return array Validation errors
      */
     protected function validateDiscount($action, $discount)
@@ -581,8 +582,7 @@ protected function _invalidateCache()
     }
 
     /**
-     * {@inheritdoc}
-     *
+     * @inheritdoc
      * @return $this
      */
     public function afterSave()
@@ -612,8 +612,7 @@ public function reindex()
     }
 
     /**
-     * {@inheritdoc}
-     *
+     * @inheritdoc
      * @return $this
      */
     public function afterDelete()
@@ -642,9 +641,9 @@ public function isRuleBehaviorChanged()
 
     /**
      * Get array with data differences
+     *
      * @param array $array1
      * @param array $array2
-     *
      * @return array
      */
     protected function dataDiff($array1, $array2)
@@ -663,6 +662,8 @@ protected function dataDiff($array1, $array2)
     }
 
     /**
+     * Get conditions field set id
+     *
      * @param string $formName
      * @return string
      */
@@ -674,79 +675,94 @@ public function getConditionsFieldSetId($formName = '')
     //@codeCoverageIgnoreStart
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @return int|null
      */
     public function getRuleId()
     {
         return $this->getData(self::RULE_ID);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @param int $ruleId
+     * @return $this
      */
     public function setRuleId($ruleId)
     {
         return $this->setData(self::RULE_ID, $ruleId);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @return string
      */
     public function getName()
     {
         return $this->getData(self::NAME);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @param string $name
+     * @return $this
      */
     public function setName($name)
     {
         return $this->setData(self::NAME, $name);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @return string|null
      */
     public function getDescription()
     {
         return $this->getData(self::DESCRIPTION);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @param string $description
+     * @return $this
      */
     public function setDescription($description)
     {
         return $this->setData(self::DESCRIPTION, $description);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @return int
      */
     public function getIsActive()
     {
         return $this->getData(self::IS_ACTIVE);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @param int $isActive
+     * @return $this
      */
     public function setIsActive($isActive)
     {
         return $this->setData(self::IS_ACTIVE, $isActive);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @return \Magento\CatalogRule\Api\Data\ConditionInterface|null
      */
     public function getRuleCondition()
     {
         return $this->getRuleConditionConverter()->arrayToDataModel($this->getConditions()->asArray());
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @param \Magento\CatalogRule\Api\Data\ConditionInterface $condition
+     * @return $this
      */
     public function setRuleCondition($condition)
     {
@@ -757,70 +773,84 @@ public function setRuleCondition($condition)
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @return int|null
      */
     public function getStopRulesProcessing()
     {
         return $this->getData(self::STOP_RULES_PROCESSING);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @param int $isStopProcessing
+     * @return $this
      */
     public function setStopRulesProcessing($isStopProcessing)
     {
         return $this->setData(self::STOP_RULES_PROCESSING, $isStopProcessing);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @return int|null
      */
     public function getSortOrder()
     {
         return $this->getData(self::SORT_ORDER);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @param int $sortOrder
+     * @return $this
      */
     public function setSortOrder($sortOrder)
     {
         return $this->setData(self::SORT_ORDER, $sortOrder);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @return string
      */
     public function getSimpleAction()
     {
         return $this->getData(self::SIMPLE_ACTION);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @param string $action
+     * @return $this
      */
     public function setSimpleAction($action)
     {
         return $this->setData(self::SIMPLE_ACTION, $action);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @return float
      */
     public function getDiscountAmount()
     {
         return $this->getData(self::DISCOUNT_AMOUNT);
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
+     * @param float $amount
+     * @return $this
      */
     public function setDiscountAmount($amount)
     {
         return $this->setData(self::DISCOUNT_AMOUNT, $amount);
     }
 
     /**
+     * Get from date
+     *
      * @return string
      */
     public function getFromDate()
@@ -829,6 +859,8 @@ public function getFromDate()
     }
 
     /**
+     * Get to date
+     *
      * @return string
      */
     public function getToDate()
@@ -837,8 +869,7 @@ public function getToDate()
     }
 
     /**
-     * {@inheritdoc}
-     *
+     * @inheritdoc
      * @return \Magento\CatalogRule\Api\Data\RuleExtensionInterface|null
      */
     public function getExtensionAttributes()
@@ -847,8 +878,7 @@ public function getExtensionAttributes()
     }
 
     /**
-     * {@inheritdoc}
-     *
+     * @inheritdoc
      * @param \Magento\CatalogRule\Api\Data\RuleExtensionInterface $extensionAttributes
      * @return $this
      */
@@ -858,6 +888,8 @@ public function setExtensionAttributes(RuleExtensionInterface $extensionAttribut
     }
 
     /**
+     * Get rule condition converter
+     *
      * @return Data\Condition\Converter
      * @deprecated 100.1.0
      */