Skip to content

Commit d094e42

Browse files
committed
AC-9246: Mark Magento_ReleaseNotification module deprecated in 2.4.7
1 parent ad8c0ca commit d094e42

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

app/code/Magento/ReleaseNotification/Controller/Adminhtml/Notification/MarkUserNotified.php

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
namespace Magento\ReleaseNotification\Controller\Adminhtml\Notification;
88

99
use Magento\Backend\App\Action;
10+
use Magento\Framework\App\Action\HttpPostActionInterface;
1011
use Magento\Framework\Exception\LocalizedException;
1112
use Magento\Framework\Controller\ResultFactory;
1213
use Magento\ReleaseNotification\Model\ResourceModel\Viewer\Logger as NotificationLogger;
@@ -18,7 +19,7 @@
1819
* in favor of another in-product messaging mechanism
1920
* @see Current in-product messaging mechanism
2021
*/
21-
class MarkUserNotified extends Action
22+
class MarkUserNotified extends Action implements HttpPostActionInterface
2223
{
2324
/**
2425
* @var ProductMetadataInterface
@@ -86,12 +87,4 @@ public function execute()
8687
$resultJson = $this->resultFactory->create(ResultFactory::TYPE_JSON);
8788
return $resultJson->setData($responseContent);
8889
}
89-
90-
/**
91-
* @return bool
92-
*/
93-
protected function _isAllowed()
94-
{
95-
return parent::_isAllowed();
96-
}
9790
}

app/code/Magento/ReleaseNotification/Model/ResourceModel/Viewer/Logger.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,9 @@
2323
class Logger
2424
{
2525
/**
26-
* Log table name
26+
* Release notification log table name
2727
*/
28-
const LOG_TABLE_NAME = 'release_notification_viewer_log';
28+
public const LOG_TABLE_NAME = 'release_notification_viewer_log';
2929

3030
/**
3131
* @var Resource

app/code/Magento/ReleaseNotification/Ui/DataProvider/NotificationDataProvider.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,20 +181,25 @@ public function getRequestFieldName()
181181

182182
/**
183183
* @inheritdoc
184+
* phpcs:disable Magento2.CodeAnalysis.EmptyBlock
184185
*/
185186
public function addFilter(\Magento\Framework\Api\Filter $filter)
186187
{
188+
// phpcs:ignore Squiz.PHP.NonExecutableCode.ReturnNotRequired
189+
return;
187190
}
188191

189192
/**
190193
* @inheritdoc
194+
* phpcs:disable Magento2.CodeAnalysis.EmptyBlock
191195
*/
192196
public function addOrder($field, $direction)
193197
{
194198
}
195199

196200
/**
197201
* @inheritdoc
202+
* phpcs:disable Magento2.CodeAnalysis.EmptyBlock
198203
*/
199204
public function setLimit($offset, $size)
200205
{

0 commit comments

Comments
 (0)