MC-13806: Replace rand with random_int

omiroshnichenko · omiroshnichenko · commit d0723579e59d · 2019-04-04T16:03:30.000-05:00
diff --git a/lib/internal/Magento/Framework/Encryption/Crypt.php b/lib/internal/Magento/Framework/Encryption/Crypt.php
@@ -66,7 +66,7 @@ public function __construct(
             $allowedCharacters = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789';
             $initVector = '';
             for ($i = 0; $i < $initVectorSize; $i++) {
-                $initVector .= $allowedCharacters[rand(0, strlen($allowedCharacters) - 1)];
+                $initVector .= $allowedCharacters[random_int(0, strlen($allowedCharacters) - 1)];
             }
             // @codingStandardsIgnoreStart
             @mcrypt_generic_deinit($handle);

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ public function __construct(`
`66`	`66`	`$allowedCharacters = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789';`
`67`	`67`	`$initVector = '';`
`68`	`68`	`for ($i = 0; $i < $initVectorSize; $i++) {`
`69`		`- $initVector .= $allowedCharacters[rand(0, strlen($allowedCharacters) - 1)];`
	`69`	`+ $initVector .= $allowedCharacters[random_int(0, strlen($allowedCharacters) - 1)];`
`70`	`70`	`}`
`71`	`71`	`// @codingStandardsIgnoreStart`
`72`	`72`	`@mcrypt_generic_deinit($handle);`