Skip to content

Commit cfe58e1

Browse files
phoenix128sanjay-wagento
authored andcommitted
Single call for getMessages() app/code/Magento/User/Test/Unit/Observer/Backend/AuthObserverTest.php is checking for a single getMessages() call
1 parent b2cc966 commit cfe58e1

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

app/code/Magento/User/Observer/Backend/AuthObserver.php

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,11 +196,13 @@ private function _checkExpiredPassword($latestPassword)
196196
$message = __('It\'s time to <a href="%1">change your password</a>.', $myAccountUrl);
197197
}
198198

199-
// Avoid duplicating the message
200-
$this->messageManager->getMessages()->deleteMessageByIdentifier(User::MESSAGE_ID_PASSWORD_EXPIRED);
199+
$messages = $this->messageManager->getMessages();
200+
201+
// Remove existing messages with same ID to avoid duplication
202+
$messages->deleteMessageByIdentifier(User::MESSAGE_ID_PASSWORD_EXPIRED);
201203

202204
$this->messageManager->addNoticeMessage($message);
203-
$message = $this->messageManager->getMessages()->getLastAddedMessage();
205+
$message = $messages->getLastAddedMessage();
204206
if ($message) {
205207
$message->setIdentifier(User::MESSAGE_ID_PASSWORD_EXPIRED)->setIsSticky(true);
206208
$this->authSession->setPciAdminUserIsPasswordExpired(true);

0 commit comments

Comments
 (0)