Skip to content

Commit cf7176d

Browse files
committed
Add missing property, add missing throws to PHPDocs
1 parent 20474b1 commit cf7176d

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

app/code/Magento/Ui/Model/Export/ConvertToCsv.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
namespace Magento\Ui\Model\Export;
77

88
use Magento\Framework\App\Filesystem\DirectoryList;
9+
use Magento\Framework\Exception\FileSystemException;
910
use Magento\Framework\Exception\LocalizedException;
1011
use Magento\Framework\Filesystem;
1112
use Magento\Framework\Filesystem\Directory\WriteInterface;
@@ -31,11 +32,17 @@ class ConvertToCsv
3132
*/
3233
protected $pageSize = null;
3334

35+
/**
36+
* @var Filter
37+
*/
38+
protected $filter;
39+
3440
/**
3541
* @param Filesystem $filesystem
3642
* @param Filter $filter
3743
* @param MetadataProvider $metadataProvider
3844
* @param int $pageSize
45+
* @throws FileSystemException
3946
*/
4047
public function __construct(
4148
Filesystem $filesystem,

app/code/Magento/Ui/Model/Export/ConvertToXml.php

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
use Magento\Framework\App\Filesystem\DirectoryList;
1111
use Magento\Framework\Convert\Excel;
1212
use Magento\Framework\Convert\ExcelFactory;
13+
use Magento\Framework\Exception\FileSystemException;
1314
use Magento\Framework\Exception\LocalizedException;
1415
use Magento\Framework\Filesystem;
1516
use Magento\Framework\Filesystem\Directory\WriteInterface;
@@ -50,12 +51,18 @@ class ConvertToXml
5051
*/
5152
protected $fields;
5253

54+
/**
55+
* @var Filter
56+
*/
57+
protected $filter;
58+
5359
/**
5460
* @param Filesystem $filesystem
5561
* @param Filter $filter
5662
* @param MetadataProvider $metadataProvider
5763
* @param ExcelFactory $excelFactory
5864
* @param SearchResultIteratorFactory $iteratorFactory
65+
* @throws FileSystemException
5966
*/
6067
public function __construct(
6168
Filesystem $filesystem,
@@ -88,6 +95,7 @@ protected function getOptions()
8895
* Returns DB fields list
8996
*
9097
* @return array
98+
* @throws LocalizedException
9199
*/
92100
protected function getFields()
93101
{
@@ -103,6 +111,7 @@ protected function getFields()
103111
*
104112
* @param DocumentInterface $document
105113
* @return array
114+
* @throws LocalizedException
106115
*/
107116
public function getRowData(DocumentInterface $document)
108117
{

0 commit comments

Comments
 (0)