MAGETWO-95595: Index names are ignored by declarative schema

fascinosum · fascinosum · commit cf6c3952630d · 2018-10-23T11:58:20.000-05:00
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Operations/AddColumn.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Operations/AddColumn.php
@@ -110,7 +110,7 @@ private function getTemporaryIndexHistory(Column $column)
             Index::TYPE,
             [
                 'name' => self::TEMPORARY_KEY,
-                'column' => $column->getName(),
+                'column' => [$column->getName()],
                 'columns' => [$column],
                 'table' => $column->getTable()
             ]
@@ -119,15 +119,15 @@ private function getTemporaryIndexHistory(Column $column)
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function getOperationName()
     {
         return self::OPERATION_NAME;
     }
 
     /**
-     * @return bool
+     * @inheritdoc
      */
     public function isOperationDestructive()
     {
@@ -187,7 +187,7 @@ private function setupTriggersIfExists(Statement $statement, ElementHistory $ele
     }
 
     /**
-     * {@inheritdoc}
+     * @inheritdoc
      */
     public function doOperation(ElementHistory $elementHistory)
     {

Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ private function getTemporaryIndexHistory(Column $column)`
`110`	`110`	`Index::TYPE,`
`111`	`111`	`[`
`112`	`112`	`'name' => self::TEMPORARY_KEY,`
`113`		`- 'column' => $column->getName(),`
	`113`	`+ 'column' => [$column->getName()],`
`114`	`114`	`'columns' => [$column],`
`115`	`115`	`'table' => $column->getTable()`
`116`	`116`	`]`
`@@ -119,15 +119,15 @@ private function getTemporaryIndexHistory(Column $column)`
`119`	`119`	`}`
`120`	`120`
`121`	`121`	`/**`
`122`		`- * {@inheritdoc}`
	`122`	`+ * @inheritdoc`
`123`	`123`	`*/`
`124`	`124`	`public function getOperationName()`
`125`	`125`	`{`
`126`	`126`	`return self::OPERATION_NAME;`
`127`	`127`	`}`
`128`	`128`
`129`	`129`	`/**`
`130`		`- * @return bool`
	`130`	`+ * @inheritdoc`
`131`	`131`	`*/`
`132`	`132`	`public function isOperationDestructive()`
`133`	`133`	`{`
`@@ -187,7 +187,7 @@ private function setupTriggersIfExists(Statement $statement, ElementHistory $ele`
`187`	`187`	`}`
`188`	`188`
`189`	`189`	`/**`
`190`		`- * {@inheritdoc}`
	`190`	`+ * @inheritdoc`
`191`	`191`	`*/`
`192`	`192`	`public function doOperation(ElementHistory $elementHistory)`
`193`	`193`	`{`