MAGETWO-92402: Write tests

Author: duhon

dev/tests/integration/framework/Magento/TestFramework/Annotation/IndexerDimensionMode.php

@@ -7,10 +7,11 @@
 namespace Magento\TestFramework\Annotation;
 
 use Magento\Catalog\Model\Indexer\Product\Price\ModeSwitcher;
+use Magento\Catalog\Model\Indexer\Product\Price\Processor;
 use Magento\Framework\App\Cache\TypeListInterface;
 use Magento\Framework\App\Config\ConfigResource\ConfigInterface;
 use Magento\Framework\App\Config\ScopeConfigInterface;
-use Magento\TestFramework\Application;
+use Magento\Framework\ObjectManagerInterface;
 use Magento\TestFramework\App\Config;
 use Magento\TestFramework\Helper\Bootstrap;
 use Magento\Catalog\Model\Indexer\Product\Price\DimensionModeConfiguration;
@@ -21,29 +22,30 @@
  */
 class IndexerDimensionMode
 {
-    protected $cacheTypeList;
+    /** @var TypeListInterface */
+    private $cacheTypeList;
+
+    /** @var ScopeConfigInterface */
     private $configReader;
 
+    /** @var ModeSwitcher */
     private $modeSwitcher;
 
+    /** @var ConfigInterface */
     private $configWriter;
 
+    /** @var ObjectManagerInterface */
+    private $objectManager;
+
+    /** @var \Magento\TestFramework\Db\Mysql */
     private $db;
 
+    /** @var bool */
     private $isDimensionMode = false;
 
-    private $objectManager;
-
-    public function __construct(Application $application)
-    {
-        $this->db = $application->getDbInstance();
-    }
-
     private function restoreDb()
     {
-        $this->db = Bootstrap::getInstance()->getBootstrap()
-            ->getApplication()
-            ->getDbInstance();
+        $this->db = Bootstrap::getInstance()->getBootstrap()->getApplication()->getDbInstance();
         $this->db->restoreFromDbDump();
         $this->cacheTypeList->cleanType('config');
         $this->objectManager->get(Config::class)->clean();
@@ -87,10 +89,9 @@ private function setDimensionMode($mode, $test)
         } else {
             $this->fail('Dimensions mode for indexer has not been changed', $test);
         }
-
     }
 
-     /**
+    /**
      * Handler for 'startTest' event
      *
      * @param TestCase $test
@@ -108,12 +109,15 @@ public function startTest(TestCase $test)
             return;
         }
 
-        $dbIsolation = $source['method']['magentoDbIsolation'] ?? $source['class']['magentoDbIsolation'] ?? ['disabled'];
+        $dbIsolation = $source['method']['magentoDbIsolation']
+            ?? $source['class']['magentoDbIsolation']
+            ?? ['disabled'];
+
         if ($dbIsolation[0] != 'disabled') {
             $this->fail("Invalid @magentoDbIsolation declaration: $dbIsolation[0]", $test);
         }
 
-        if ($annotations[0] == 'price') {
+        if ($annotations[0] == Processor::INDEXER_ID) {
             $this->isDimensionMode = true;
             $this->setDimensionMode(DimensionModeConfiguration::DIMENSION_WEBSITE_AND_CUSTOMER_GROUP, $test);
         }

dev/tests/integration/testsuite/Magento/Bundle/Model/Product/DynamicBundlePriceCalculatorWithDimensionTest.php

@@ -8,7 +8,7 @@
 
 /**
  * @magentoDbIsolation disabled
- * @magentoIndexerDimensionMode price
+ * @magentoIndexerDimensionMode catalog_product_price website_and_customer_group
  * @group indexer_dimension
  * @magentoAppArea frontend
  */

dev/tests/integration/testsuite/Magento/Bundle/Model/Product/FixedBundlePriceCalculatorWithDimensionTest.php

@@ -10,7 +10,7 @@
 
 /**
  * @magentoDbIsolation disabled
- * @magentoIndexerDimensionMode price
+ * @magentoIndexerDimensionMode catalog_product_price website_and_customer_group
  * @group indexer_dimension
  * @magentoAppArea frontend
  */

dev/tests/integration/testsuite/Magento/Bundle/Model/Product/PriceWithDimensionTest.php

@@ -7,7 +7,7 @@
 
 /**
  * @magentoDbIsolation disabled
- * @magentoIndexerDimensionMode price
+ * @magentoIndexerDimensionMode catalog_product_price website_and_customer_group
  * @group indexer_dimension
  * @magentoDataFixture Magento/Bundle/_files/product_with_tier_pricing.php
  */

dev/tests/integration/testsuite/Magento/Catalog/Model/Indexer/Product/Price/SimpleWithOptionsTierPriceWithDimensionTest.php

@@ -42,7 +42,7 @@ protected function setUp()
 
     /**
      * @magentoDbIsolation disabled
-     * @magentoIndexerDimensionMode price
+     * @magentoIndexerDimensionMode catalog_product_price website_and_customer_group
      * @magentoDataFixture Magento/Catalog/_files/category_product.php
      */
     public function testTierPrice()

dev/tests/integration/testsuite/Magento/Catalog/Model/Product/Type/PriceWithDimensionTest.php

@@ -9,7 +9,7 @@
 
 /**
  * @magentoDbIsolation disabled
- * @magentoIndexerDimensionMode price
+ * @magentoIndexerDimensionMode catalog_product_price website_and_customer_group
  * @group indexer_dimension
  * @magentoDataFixture Magento/Catalog/_files/product_simple.php
  */

dev/tests/integration/testsuite/Magento/Catalog/Model/ProductPriceWithDimensionTest.php

@@ -83,7 +83,7 @@ public function testSetGetFinalPrice()
 
     /**
      * @magentoDbIsolation disabled
-     * @magentoIndexerDimensionMode price
+     * @magentoIndexerDimensionMode catalog_product_price website_and_customer_group
      * @magentoDataFixture Magento/Catalog/_files/product_with_options.php
      */
     public function testGetMinPrice()
@@ -100,7 +100,7 @@ public function testGetMinPrice()
 
     /**
      * @magentoDbIsolation disabled
-     * @magentoIndexerDimensionMode price
+     * @magentoIndexerDimensionMode catalog_product_price website_and_customer_group
      * @magentoDataFixture Magento/ConfigurableProduct/_files/product_configurable_sku.php
      */
     public function testGetMinPriceForComposite()

dev/tests/integration/testsuite/Magento/ConfigurableProduct/Pricing/Price/SpecialPriceIndexerWithDimensionTest.php

@@ -16,7 +16,7 @@
 /**
  * @magentoDbIsolation disabled
  * @group indexer_dimension
- * @magentoIndexerDimensionMode price
+ * @magentoIndexerDimensionMode catalog_product_price website_and_customer_group
  */
 class SpecialPriceIndexerWithDimensionTest extends \PHPUnit\Framework\TestCase
 {

dev/tests/integration/testsuite/Magento/ConfigurableProduct/Pricing/Render/FinalPriceBox/RenderingBasedOnIsProductListFlagWithDimensionTest.php

@@ -16,7 +16,7 @@
 
 /**
  * @magentoDbIsolation disabled
- * @magentoIndexerDimensionMode price
+ * @magentoIndexerDimensionMode catalog_product_price website_and_customer_group
  * @group indexer_dimension
  * Test price rendering according to is_product_list flag for Configurable product
  */