MAGETWO-94482: [2.3] Fixed procedure of creating mapping for dynamic fields in elasticsearch

- fix tests

Author: vgoncharenko

app/code/Magento/Elasticsearch/Elasticsearch5/Model/Adapter/FieldMapper/Product/FieldProvider/FieldType/Resolver/CompositeResolver.php

@@ -28,8 +28,8 @@ public function __construct(array $items)
             if (!$item instanceof ResolverInterface) {
                 throw new \InvalidArgumentException(
                     sprintf('Instance of the field type resolver is expected, got %s instead.', get_class($item))
-               );
-           }
+                );
+            }
         }
         $this->items = $items;
     }

app/code/Magento/Elasticsearch/Model/Adapter/FieldMapper/Product/AttributeAdapter/DummyAttribute.php

@@ -9,6 +9,7 @@
 
 /**
  * Dummy class for Not EAV attribute.
+ * @SuppressWarnings(PHPMD)
  */
 class DummyAttribute implements CustomAttributesDataInterface
 {

app/code/Magento/Elasticsearch/Test/Unit/Model/Adapter/FieldMapper/Product/FieldProvider/FieldName/Resolver/NotEavAttributeTest.php

@@ -6,20 +6,17 @@
 
 namespace Magento\Elasticsearch\Test\Unit\Model\Adapter\FieldMapper\Product\FieldProvider\FieldName\Resolver;
 
-use Magento\Catalog\Api\Data\CategoryInterface;
 use Magento\Elasticsearch\Model\Adapter\FieldMapper\Product\AttributeAdapter;
 use Magento\Framework\TestFramework\Unit\Helper\ObjectManager as ObjectManagerHelper;
-use Magento\Framework\Registry;
-use Magento\Store\Model\StoreManagerInterface as StoreManager;
-use Magento\Store\Api\Data\StoreInterface;
+use Magento\Elasticsearch\Model\Adapter\FieldMapper\Product\FieldProvider\FieldName\Resolver\NotEavAttribute;
 
 /**
  * @SuppressWarnings(PHPMD)
  */
 class NotEavAttributeTest extends \PHPUnit\Framework\TestCase
 {
     /**
-     * @var \Magento\Elasticsearch\Model\Adapter\FieldMapper\Product\FieldProvider\FieldName\Resolver\NotEavAttribute
+     * @var NotEavAttribute
      */
     private $resolver;
 
@@ -33,7 +30,7 @@ protected function setUp()
         $objectManager = new ObjectManagerHelper($this);
 
         $this->resolver = $objectManager->getObject(
-            \Magento\Elasticsearch\Model\Adapter\FieldMapper\Product\FieldProvider\FieldName\Resolver\NotEavAttribute::class
+            NotEavAttribute::class
         );
     }