Skip to content

Commit cf0bad5

Browse files
committed
Integration test fix
1 parent ccb9e8a commit cf0bad5

File tree

3 files changed

+43
-18
lines changed

3 files changed

+43
-18
lines changed

app/code/Magento/Catalog/Model/Indexer/Category/Product/Plugin/TableResolver.php

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
namespace Magento\Catalog\Model\Indexer\Category\Product\Plugin;
88

99
use Magento\Framework\App\ResourceConnection;
10-
use Magento\Framework\App\State;
1110
use Magento\Store\Model\StoreManagerInterface;
1211
use Magento\Framework\Indexer\ScopeResolver\IndexScopeResolver;
1312
use Magento\Catalog\Model\Indexer\Category\Product\AbstractAction;
@@ -28,24 +27,16 @@ class TableResolver
2827
*/
2928
private $tableResolver;
3029

31-
/**
32-
* @var State
33-
*/
34-
private $state;
35-
3630
/**
3731
* @param StoreManagerInterface $storeManager
3832
* @param IndexScopeResolver $tableResolver
39-
* @param State $state
4033
*/
4134
public function __construct(
4235
StoreManagerInterface $storeManager,
43-
IndexScopeResolver $tableResolver,
44-
State $state
36+
IndexScopeResolver $tableResolver
4537
) {
4638
$this->storeManager = $storeManager;
4739
$this->tableResolver = $tableResolver;
48-
$this->state = $state;
4940
}
5041

5142
/**
@@ -64,14 +55,9 @@ public function afterGetTableName(
6455
string $result,
6556
$modelEntity
6657
) {
67-
$objectManager = \Magento\Framework\App\ObjectManager::getInstance();
68-
$state = $objectManager->get('Magento\Framework\App\State');
69-
$areaCode = $state->getAreaCode();
70-
7158
if (!is_array($modelEntity) &&
7259
$modelEntity === AbstractAction::MAIN_INDEX_TABLE &&
73-
$this->storeManager->getStore()->getId() &&
74-
$areaCode != 'adminhtml'
60+
$this->storeManager->getStore()->getId()
7561
) {
7662
$catalogCategoryProductDimension = new Dimension(
7763
\Magento\Store\Model\Store::ENTITY,

app/code/Magento/Catalog/Model/ResourceModel/Category/Collection.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,6 @@ private function getProductsCountFromCategoryTable(Category $item, string $websi
568568
private function getProductsCountQuery(array $categoryIds, $addVisibilityFilter = true): Select
569569
{
570570
$categoryTable = $this->_resource->getTableName('catalog_category_product_index');
571-
572571
$select = $this->_conn->select()
573572
->from(
574573
['cat_index' => $categoryTable],

dev/tests/integration/testsuite/Magento/Catalog/Block/Adminhtml/Category/Checkboxes/TreeTest.php

Lines changed: 41 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,47 @@ public function testSetGetCategoryIds(): void
6464
*/
6565
public function testGetTreeJson(): void
6666
{
67-
$jsonTree = $this->block->getTreeJson();
67+
$categoryFactoryMock = $this->getMockBuilder(\Magento\Catalog\Model\CategoryFactory::class)
68+
->onlyMethods(['create'])
69+
->disableOriginalConstructor()
70+
->getMock();
71+
72+
$categoryMock = $this->getMockBuilder(\Magento\Catalog\Model\Category::class)
73+
->onlyMethods(['getCollection'])
74+
->disableOriginalConstructor()
75+
->getMock();
76+
77+
// create resource connection mock
78+
$resourceConnection = $this->getMockBuilder(\Magento\Framework\App\ResourceConnection::class)
79+
->onlyMethods(['getTableName'])
80+
->disableOriginalConstructor()
81+
->getMock();
82+
83+
$resourceConnection->method('getTableName')
84+
->willReturn('catalog_category_product_index');
85+
86+
$categoryFactoryMock->method('create')
87+
->willReturn($categoryMock);
88+
89+
$categoryCollection = $this->objectManager->create(
90+
\Magento\Catalog\Model\ResourceModel\Category\Collection::class,
91+
[
92+
'resource' => $resourceConnection
93+
]
94+
);
95+
96+
$categoryMock->method('getCollection')
97+
->willReturn($categoryCollection);
98+
99+
$treeObject = $this->objectManager->create(
100+
\Magento\Catalog\Block\Adminhtml\Category\Checkboxes\Tree::class,
101+
[
102+
'categoryFactory' => $categoryFactoryMock
103+
]
104+
);
105+
106+
$jsonTree = $treeObject->getTreeJson();
107+
68108
$this->assertStringContainsString('Default Category (4)', $jsonTree);
69109
$this->assertStringContainsString('Category 1.1 (2)', $jsonTree);
70110
$this->assertStringContainsString('Category 1.1.1 (1)', $jsonTree);

0 commit comments

Comments
 (0)