Skip to content

Commit cef3273

Browse files
author
Oleksandr Dubovyk
committed
MC-40982: Duplicate ID issue on the customer login page
- fixed - modified test
1 parent fc11eb9 commit cef3273

File tree

3 files changed

+14
-3
lines changed

3 files changed

+14
-3
lines changed

app/design/frontend/Magento/blank/Magento_Theme/web/js/theme.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ define([
1717
});
1818

1919
$('.panel.header > .header.links').clone().appendTo('#store\\.links');
20-
$('#store\\.links .customer-menu li a').each(function () {
20+
$('#store\\.links li a').each(function () {
2121
var id = $(this).attr('id');
2222

2323
if (id !== undefined) {

dev/tests/js/jasmine/assets/lib/web/mage/account_menu.html

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<span>Change</span>
1818
</button>
1919
</span>
20-
20+
<!-- Markup portion for Logged in customer -->
2121
<div class="customer-menu" data-target="dropdown" aria-hidden="false">
2222
<ul class="header links">
2323
<li>
@@ -37,9 +37,16 @@
3737
</li>
3838
</ul>
3939
</div>
40+
<li class="link authorization-link" data-label="or">
41+
<a href="http://magento.store/customer/account/logout/">Sign Out</a>
42+
</li>
4043
</li>
44+
<!-- Markup portion for Logged out customer -->
4145
<li class="link authorization-link" data-label="or">
42-
<a href="http://magento.store/customer/account/logout/">Sign Out</a>
46+
<a href="http://magento.store/customer/account/login/">Sign In</a>
47+
</li>
48+
<li>
49+
<a href="http://magento.store/customer/account/create/" id="create-account">Create an Account</a>
4350
</li>
4451
</ul>
4552
</div>

dev/tests/js/jasmine/tests/app/code/Magento/Theme/view/frontend/web/js/theme.test.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,10 @@ define([
5353
{
5454
id: '#my-addresses' + suffix,
5555
link: 'http://magento.store/addresses/'
56+
},
57+
{
58+
id: '#create-account' + suffix,
59+
link: 'http://magento.store/customer/account/create/'
5660
}
5761
];
5862

0 commit comments

Comments
 (0)