Merge remote-tracking branch 'magento-engcom/imported-magento-magento2-32733' into api-changes-delivery

Gabriel Galvao da Gama · Gabriel Galvao da Gama · commit cdb3a171dabe · 2021-04-22T12:37:13.000+01:00
diff --git a/lib/internal/Magento/Framework/Setup/ConfigOptionsListInterface.php b/lib/internal/Magento/Framework/Setup/ConfigOptionsListInterface.php
@@ -3,12 +3,16 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup;
 
 use Magento\Framework\App\DeploymentConfig;
 
 /**
  * Interface for handling options in deployment configuration tool
+ *
+ * @api
  */
 interface ConfigOptionsListInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/DataCacheInterface.php b/lib/internal/Magento/Framework/Setup/DataCacheInterface.php
@@ -3,10 +3,14 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup;
 
 /**
  * Data setup cache
+ *
+ * @api
  */
 interface DataCacheInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/DataSavior/DataSaviorInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/DataSavior/DataSaviorInterface.php
@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Framework\Setup\Declaration\Schema\DataSavior;
 
@@ -11,6 +12,8 @@
 /**
  * This interface allows to dump data during declarative installation process
  * and revert changes with applying previously saved data, if something goes wrong
+ *
+ * @api
  */
 interface DataSaviorInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/DataSavior/DumpAccessorInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/DataSavior/DumpAccessorInterface.php
@@ -3,11 +3,14 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Framework\Setup\Declaration\Schema\DataSavior;
 
 /**
  * Allows to access dump, that can be persisted in any file format or in database
+ *
+ * @api
  */
 interface DumpAccessorInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/DDLTriggerInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/DDLTriggerInterface.php
@@ -25,6 +25,8 @@
  * This approach is correct from prospective of declaration but is not so fast as ALTER TABLE is.
  * So if you need to perform some renaming operations quickly, please use raw SQL dump instead, that can be taken with
  * help of --dry-run mode
+ *
+ * @api
  */
 interface DDLTriggerInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/DbDefinitionProcessorInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/DbDefinitionProcessorInterface.php
@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Framework\Setup\Declaration\Schema\Db;
 
@@ -13,6 +14,8 @@
  * For example, from VARCHAR(255) to:
  * 'type' => 'varchar'
  * 'length' => 255
+ *
+ * @api
  */
 interface DbDefinitionProcessorInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/DbSchemaReaderInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/DbSchemaReaderInterface.php
@@ -3,12 +3,15 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Framework\Setup\Declaration\Schema\Db;
 
 /**
  * This class is responsible for read different schema
  * structural elements: indexes, constraints, table names and columns.
+ *
+ * @api
  */
 interface DbSchemaReaderInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/DbSchemaWriterInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/DbSchemaWriterInterface.php
@@ -3,12 +3,15 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Framework\Setup\Declaration\Schema\Db;
 
 /**
  * This class is responsible for read different schema structural elements: indexes, constraints,
  * table names and columns.
+ *
+ * @api
  */
 interface DbSchemaWriterInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/StatementAggregator.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Db/StatementAggregator.php
@@ -10,6 +10,8 @@
  * Statement aggregator.
  *
  * Statements are concatenated conditionally, decides which statements go separately and which may be concatenated.
+ *
+ * @api
  */
 class StatementAggregator
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Declaration/ValidationInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Declaration/ValidationInterface.php
@@ -3,12 +3,16 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup\Declaration\Schema\Declaration;
 
 use Magento\Framework\Setup\Declaration\Schema\Dto\Schema;
 
 /**
  * This class is responsible for basic validation rules.
+ *
+ * @api
  */
 interface ValidationInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Diff/DiffInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Diff/DiffInterface.php
@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Framework\Setup\Declaration\Schema\Diff;
 
@@ -11,6 +12,8 @@
 /**
  * DiffInterface is type of classes, that holds all information
  * that need to be changed from one installation to another.
+ *
+ * @api
  */
 interface DiffInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Columns/ColumnDefaultAwareInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Columns/ColumnDefaultAwareInterface.php
@@ -3,10 +3,14 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup\Declaration\Schema\Dto\Columns;
 
 /**
  * Provides default value for column.
+ *
+ * @api
  */
 interface ColumnDefaultAwareInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Columns/ColumnIdentityAwareInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Columns/ColumnIdentityAwareInterface.php
@@ -3,10 +3,14 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup\Declaration\Schema\Dto\Columns;
 
 /**
  * Provides auto_increment flag for column.
+ *
+ * @api
  */
 interface ColumnIdentityAwareInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Columns/ColumnNullableAwareInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Columns/ColumnNullableAwareInterface.php
@@ -3,11 +3,15 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup\Declaration\Schema\Dto\Columns;
 
 /**
  * Provides nullable flag for element.
  * If column element implement this interface, then it will have NULL or NOT NULL flag in column definition.
+ *
+ * @api
  */
 interface ColumnNullableAwareInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Columns/ColumnUnsignedAwareInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Columns/ColumnUnsignedAwareInterface.php
@@ -3,12 +3,16 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup\Declaration\Schema\Dto\Columns;
 
 /**
  * Unsigned flag provider for element.
  * If column element implement this interface, then it will have UNSIGNED flag in column
  * definition.
+ *
+ * @api
  */
 interface ColumnUnsignedAwareInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/ElementDiffAwareInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/ElementDiffAwareInterface.php
@@ -3,12 +3,16 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup\Declaration\Schema\Dto;
 
 /**
  * Element diff provider interface.
  *
  * This interface provides all params, that should participate in elements comparison.
+ *
+ * @api
  */
 interface ElementDiffAwareInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Factories/FactoryInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Factories/FactoryInterface.php
@@ -3,12 +3,16 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup\Declaration\Schema\Dto\Factories;
 
 use Magento\Framework\Setup\Declaration\Schema\Dto\ElementInterface;
 
 /**
  * DTO Element Factory Interface.
+ *
+ * @api
  */
 interface FactoryInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Schema.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Schema.php
@@ -11,6 +11,8 @@
  * Schema DTO element.
  *
  * Aggregation root for all structural elements. Provides access to tables by their names.
+ *
+ * @api
  */
 class Schema
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Table.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/Table.php
@@ -13,6 +13,8 @@
  * Table structural element
  * Aggregate inside itself: columns, constraints and indexes
  * Resource is also specified on this strucural element
+ *
+ * @api
  */
 class Table extends GenericElement implements
     ElementInterface,
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/TableElementInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/Dto/TableElementInterface.php
@@ -3,12 +3,16 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup\Declaration\Schema\Dto;
 
 /**
  * Table DTO Element interface.
  *
  * This interface can be used for elements that hold tables, like constraints.
+ *
+ * @api
  */
 interface TableElementInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/ElementHistory.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/ElementHistory.php
@@ -12,6 +12,8 @@
  * Element history container.
  *
  * This class holds history about element modifications.
+ *
+ * @api
  */
 class ElementHistory
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/OperationInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/OperationInterface.php
@@ -3,13 +3,16 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Framework\Setup\Declaration\Schema;
 
 use Magento\Framework\Setup\Declaration\Schema\Db\Statement;
 
 /**
  * Schema operation interface.
+ *
+ * @api
  */
 interface OperationInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Declaration/Schema/SchemaConfigInterface.php b/lib/internal/Magento/Framework/Setup/Declaration/Schema/SchemaConfigInterface.php
@@ -3,6 +3,7 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
 
 namespace Magento\Framework\Setup\Declaration\Schema;
 
@@ -14,6 +15,8 @@
  * Used to fetch schema object with data from either db or XML file.
  *
  * Declaration has 2 schema builders, that build schema from db and from XML.
+ *
+ * @api
  */
 interface SchemaConfigInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Patch/DataPatchInterface.php b/lib/internal/Magento/Framework/Setup/Patch/DataPatchInterface.php
@@ -3,11 +3,15 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup\Patch;
 
 /**
  * This interface describe script, that atomic operations with data (DML, DQL) in SQL database
  * This is wrapper for @see PatchInterface in order to define what kind of patch we have
+ *
+ * @api
  */
 interface DataPatchInterface extends PatchInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Patch/DependentPatchInterface.php b/lib/internal/Magento/Framework/Setup/Patch/DependentPatchInterface.php
@@ -3,6 +3,8 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup\Patch;
 
 /**
@@ -14,6 +16,8 @@
  * Patch1
  *
  * Here you see dependency of Patch1 to Patch2
+ *
+ * @api
  */
 interface DependentPatchInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Patch/NonTransactionableInterface.php b/lib/internal/Magento/Framework/Setup/Patch/NonTransactionableInterface.php
@@ -3,10 +3,14 @@
  * Copyright © Magento, Inc. All rights reserved.
  * See COPYING.txt for license details.
  */
+declare(strict_types=1);
+
 namespace Magento\Framework\Setup\Patch;
 
 /**
  * Means that patch can`t be run in transaction
+ *
+ * @api
  */
 interface NonTransactionableInterface
 {
diff --git a/lib/internal/Magento/Framework/Setup/Patch/PatchInterface.php b/lib/internal/Magento/Framework/Setup/Patch/PatchInterface.php
diff --git a/lib/internal/Magento/Framework/Setup/Patch/PatchRevertableInterface.php b/lib/internal/Magento/Framework/Setup/Patch/PatchRevertableInterface.php
diff --git a/lib/internal/Magento/Framework/Setup/Patch/SchemaPatchInterface.php b/lib/internal/Magento/Framework/Setup/Patch/SchemaPatchInterface.php
diff --git a/lib/internal/Magento/Framework/Setup/SampleData/InstallerInterface.php b/lib/internal/Magento/Framework/Setup/SampleData/InstallerInterface.php
diff --git a/lib/internal/Magento/Framework/Setup/SampleData/StateInterface.php b/lib/internal/Magento/Framework/Setup/SampleData/StateInterface.php
diff --git a/lib/internal/Magento/Framework/Setup/SchemaListenerDefinition/DefinitionConverterInterface.php b/lib/internal/Magento/Framework/Setup/SchemaListenerDefinition/DefinitionConverterInterface.php
diff --git a/lib/internal/Magento/Framework/Setup/SchemaListenerHandlers/SchemaListenerHandlerInterface.php b/lib/internal/Magento/Framework/Setup/SchemaListenerHandlers/SchemaListenerHandlerInterface.php
diff --git a/lib/internal/Magento/Framework/Setup/UpToDateValidatorInterface.php b/lib/internal/Magento/Framework/Setup/UpToDateValidatorInterface.php

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,8 @@`
`25`	`25`	`* This approach is correct from prospective of declaration but is not so fast as ALTER TABLE is.`
`26`	`26`	`* So if you need to perform some renaming operations quickly, please use raw SQL dump instead, that can be taken with`
`27`	`27`	`* help of --dry-run mode`
	`28`	`+ *`
	`29`	`+ * @api`
`28`	`30`	`*/`
`29`	`31`	`interface DDLTriggerInterface`
`30`	`32`	`{`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,8 @@`
`10`	`10`	`* Statement aggregator.`
`11`	`11`	`*`
`12`	`12`	`* Statements are concatenated conditionally, decides which statements go separately and which may be concatenated.`
	`13`	`+ *`
	`14`	`+ * @api`
`13`	`15`	`*/`
`14`	`16`	`class StatementAggregator`
`15`	`17`	`{`