magento/magento2#: Remove a redundant getMappedNums from a loop

Alex Taranovskyi · Alex Taranovskyi · commit cd9e834a2f1b · 2020-09-02T15:12:17.000+03:00
diff --git a/lib/internal/Magento/Framework/GraphQl/Query/EnumLookup.php b/lib/internal/Magento/Framework/GraphQl/Query/EnumLookup.php
@@ -52,7 +52,7 @@ public function getEnumValueFromField(string $enumName, string $fieldValue) : st
         $mappedValues = $this->enumDataMapper->getMappedEnums($enumName);
 
         foreach ($enumObject->getValues() as $enumItem) {
-            if (isset($mappedValues[$enumItem->getName()]) && $mappedValues[$enumItem->getName()] == $fieldValue) {
+            if (isset($mappedValues[$enumItem->getName()]) && $mappedValues[$enumItem->getName()] === $fieldValue) {
                 return $enumItem->getValue();
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ public function getEnumValueFromField(string $enumName, string $fieldValue) : st`
`52`	`52`	`$mappedValues = $this->enumDataMapper->getMappedEnums($enumName);`
`53`	`53`
`54`	`54`	`foreach ($enumObject->getValues() as $enumItem) {`
`55`		`- if (isset($mappedValues[$enumItem->getName()]) && $mappedValues[$enumItem->getName()] == $fieldValue) {`
	`55`	`+ if (isset($mappedValues[$enumItem->getName()]) && $mappedValues[$enumItem->getName()] === $fieldValue) {`
`56`	`56`	`return $enumItem->getValue();`
`57`	`57`	`}`
`58`	`58`	`}`