Skip to content

Commit cd4aa01

Browse files
committed
MC-32651: A Gift Card with minimum value of an open amount, greater than maximum value, can be created
1 parent b5d7a7b commit cd4aa01

File tree

1 file changed

+14
-6
lines changed
  • app/code/Magento/Ui/view/base/web/js/lib/validation

1 file changed

+14
-6
lines changed

app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -836,14 +836,18 @@ define([
836836
],
837837
'less-than-equals-to': [
838838
function (value, params) {
839-
if (!$.isNumeric(params)) {
839+
value = utils.parseNumber(value);
840+
841+
if (isNaN(parseFloat(params))) {
840842
params = $(params).val();
841843
}
842844

843-
if ($.isNumeric(params) && $.isNumeric(value)) {
845+
params = utils.parseNumber(params);
846+
847+
if (!isNaN(params) && !isNaN(value)) {
844848
this.lteToVal = params;
845849

846-
return parseFloat(value) <= parseFloat(params);
850+
return value <= params;
847851
}
848852

849853
return true;
@@ -854,14 +858,18 @@ define([
854858
],
855859
'greater-than-equals-to': [
856860
function (value, params) {
857-
if (!$.isNumeric(params)) {
861+
value = utils.parseNumber(value);
862+
863+
if (isNaN(parseFloat(params))) {
858864
params = $(params).val();
859865
}
860866

861-
if ($.isNumeric(params) && $.isNumeric(value)) {
867+
params = utils.parseNumber(params);
868+
869+
if (!isNaN(params) && !isNaN(value)) {
862870
this.gteToVal = params;
863871

864-
return parseFloat(value) >= parseFloat(params);
872+
return value >= params;
865873
}
866874

867875
return true;

0 commit comments

Comments
 (0)