MAGETWO-56317: [GitHub] -[2.1.0] underscore in site url breaks admin redirect - The page isn't redirecting properly #5809

Bohdan Korablov · Bohdan Korablov · commit cd0ad2858fc4 · 2016-10-20T10:30:55.000+03:00
diff --git a/app/code/Magento/Config/Model/Config/Backend/Baseurl.php b/app/code/Magento/Config/Model/Config/Backend/Baseurl.php
@@ -202,10 +202,7 @@ private function _validateFullyQualifiedUrl($value)
      */
     private function _isFullyQualifiedUrl($value)
     {
-        $url = parse_url($value);
-
-        return isset($url['scheme']) && isset($url['host']) && preg_match('/\/$/', $value)
-            && $this->getSimpleUrlValidator()->isValid($value);
+        return preg_match('/\/$/', $value) && $this->getSimpleUrlValidator()->isValid($value);
     }
 
     /**
@@ -229,7 +226,7 @@ public function afterSave()
     }
 
     /**
-     * Get link interface factory
+     * Get Simple URL Validator
      *
      * @deprecated
      * @return SimpleValidator

Original file line number	Diff line number	Diff line change
`@@ -202,10 +202,7 @@ private function _validateFullyQualifiedUrl($value)`
`202`	`202`	`*/`
`203`	`203`	`private function _isFullyQualifiedUrl($value)`
`204`	`204`	`{`
`205`		`- $url = parse_url($value);`
`206`		`-`
`207`		`- return isset($url['scheme']) && isset($url['host']) && preg_match('/\/$/', $value)`
`208`		`- && $this->getSimpleUrlValidator()->isValid($value);`
	`205`	`+ return preg_match('/\/$/', $value) && $this->getSimpleUrlValidator()->isValid($value);`
`209`	`206`	`}`
`210`	`207`
`211`	`208`	`/**`
`@@ -229,7 +226,7 @@ public function afterSave()`
`229`	`226`	`}`
`230`	`227`
`231`	`228`	`/**`
`232`		`- * Get link interface factory`
	`229`	`+ * Get Simple URL Validator`
`233`	`230`	`*`
`234`	`231`	`* @deprecated`
`235`	`232`	`* @return SimpleValidator`