Skip to content

Commit ccff810

Browse files
shashikant.kumarshanthi
authored andcommitted
implemented review comment as element parameterized
1 parent e013310 commit ccff810

File tree

5 files changed

+6
-22
lines changed

5 files changed

+6
-22
lines changed

app/code/Magento/Catalog/Test/Mftf/ActionGroup/AdminDeleteCreatedColorSpecificAttributeActionGroup.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
<click selector="{{AdminProductAttributeGridSection.Search}}" stepKey="searchForAttributeFromTheGrid"/>
2222
<click selector="{{AdminProductAttributeGridSection.FirstRow}}" stepKey="clickOnAttributeRow"/>
2323
<waitForPageLoad stepKey="waitForPageLoad2"/>
24-
<click selector="{{AdminColorGridBodySection.deleteSpecificColorAttribute(Color)}}" stepKey="deleteColor"/>
24+
<click selector="{{AdminProductAttributeGridSection.deleteSpecificColorAttribute(Color)}}" stepKey="deleteColor"/>
2525
<waitForPageLoad stepKey="waitForPageLoad3"/>
2626
<click selector="{{AttributePropertiesSection.Save}}" stepKey="saveTheDeletedColor"/>
2727
<see userInput="You saved the product attribute." stepKey="seeSuccessMessage"/>

app/code/Magento/Catalog/Test/Mftf/Section/AdminColorGridBodySection.xml

Lines changed: 0 additions & 15 deletions
This file was deleted.

app/code/Magento/Catalog/Test/Mftf/Section/AdminProductAttributeGridSection.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
<element name="isSearchableColumn" type="text" selector="//div[@id='attributeGrid']//td[contains(@class,'a-center col-is_searchable')]"/>
2525
<element name="isComparableColumn" type="text" selector="//div[@id='attributeGrid']//td[contains(@class,'a-center col-is_comparable')]"/>
2626
<element name="addSelected" type="button" selector="//*[contains(text(),'Add Selected')]" timeout="30"/>
27+
<element name="deleteSpecificColorAttribute" type="button" selector="//input[@value='{{var}}']/../..//button[@class='action- scalable delete delete-option']" parameterized="true"/>
2728
</section>
2829
</sections>
2930

app/code/Magento/Multishipping/Test/Mftf/Section/MultishippingSection/MultishippingSection.xml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,6 @@
1919
<element name="removeItemButton" type="button" selector="//a[contains(@title, 'Remove Item')][{{var}}]" parameterized="true"/>
2020
<element name="back" type="button" selector=".action.back"/>
2121
<element name="addressSection" type="text" selector="//div[@class='block-title']/strong[text()='Address {{var}} ']" parameterized="true"/>
22-
<element name="firstFlatRateCharge" type="text" selector="//span[@class='price' and text()='$10.00']/../../label[contains(text(),'Fixed')]"/>
23-
<element name="secondFlatRateCharge" type="text" selector="//span[@class='price' and text()='$15.00']/../../label[contains(text(),'Fixed')]"/>
24-
<element name="thirdFlatRateCharge" type="text" selector="//span[@class='price' and text()='$30.00']/../../label[contains(text(),'Fixed')]"/>
22+
<element name="FlatRateCharge" type="text" selector="//span[@class='price' and text()='${{price}}']/../../label[contains(text(),'Fixed')]" parameterized="true"/>
2523
</section>
2624
</sections>

app/code/Magento/Multishipping/Test/Mftf/Test/MultishipmentCheckoutWithDifferentProductTest.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -346,9 +346,9 @@
346346
<seeElement selector="{{MultishippingSection.addressSection('2')}}" stepKey="secondAddressSection"/>
347347
<seeElement selector="{{MultishippingSection.addressSection('3')}}" stepKey="thirdAddressSection"/>
348348
<!--verify flat rate charge for all three section-->
349-
<seeElement selector="{{MultishippingSection.firstFlatRateCharge}}" stepKey="verifyFirstFlatRateAmount"/>
350-
<seeElement selector="{{MultishippingSection.secondFlatRateCharge}}" stepKey="verifySecondFlatRateAmount"/>
351-
<seeElement selector="{{MultishippingSection.thirdFlatRateCharge}}" stepKey="verifyThirdFlatRateAmount"/>
349+
<seeElement selector="{{MultishippingSection.FlatRateCharge('10.00')}}" stepKey="verifyFirstFlatRateAmount"/>
350+
<seeElement selector="{{MultishippingSection.FlatRateCharge('15.00')}}" stepKey="verifySecondFlatRateAmount"/>
351+
<seeElement selector="{{MultishippingSection.FlatRateCharge('30.00')}}" stepKey="verifyThirdFlatRateAmount"/>
352352
<!-- Click On Continue to Billing-->
353353
<click selector="{{StorefrontMultishippingCheckoutShippingToolbarSection.continueToBilling}}" stepKey="clickContinueToBilling"/>
354354
<waitForPageLoad stepKey="waitForCheckoutShippingToolbarPageLoad"/>

0 commit comments

Comments
 (0)