MAGETWO-42994: Customer custom attribute is not validated on frontend

Author: Sergey Semenov

app/code/Magento/Eav/Model/Entity/Attribute/Frontend/AbstractFrontend.php

@@ -161,7 +161,7 @@ public function getClass()
             $out[] = implode(' ', $textLengthValidateClasses);
         }
 
-        $out = !empty($out) ? implode(' ', $out) : '';
+        $out = !empty($out) ? trim(implode(' ', $out)) : '';
         return $out;
     }
 
@@ -208,15 +208,17 @@ private function getTextLengthValidateClasses()
     {
         $classes = [];
 
-        $validateRules = $this->getAttribute()->getValidateRules();
-        if (!empty($validateRules['min_text_length'])) {
-            $classes[] = 'minimum-length-' . $validateRules['min_text_length'];
-        }
-        if (!empty($validateRules['max_text_length'])) {
-            $classes[] = 'maximum-length-' . $validateRules['max_text_length'];
-        }
-        if (!empty($classes)) {
-            $classes[] = 'validate-length';
+        if ($this->_getInputValidateClass()) {
+            $validateRules = $this->getAttribute()->getValidateRules();
+            if (!empty($validateRules['min_text_length'])) {
+                $classes[] = 'minimum-length-' . $validateRules['min_text_length'];
+            }
+            if (!empty($validateRules['max_text_length'])) {
+                $classes[] = 'maximum-length-' . $validateRules['max_text_length'];
+            }
+            if (!empty($classes)) {
+                $classes[] = 'validate-length';
+            }
         }
 
         return $classes;

app/code/Magento/Eav/Test/Unit/Model/Entity/Attribute/Frontend/DefaultFrontendTest.php

@@ -32,7 +32,6 @@ protected function setUp()
 
     public function testGetClassEmpty()
     {
-        /** @var \PHPUnit_Framework_MockObject_MockObject $attributeMock */
         $attributeMock = $this->getMockBuilder('Magento\Eav\Model\Entity\Attribute\AbstractAttribute')
             ->disableOriginalConstructor()
             ->setMethods([
@@ -57,7 +56,6 @@ public function testGetClassEmpty()
 
     public function testGetClass()
     {
-        /** @var \PHPUnit_Framework_MockObject_MockObject $attributeMock */
         $attributeMock = $this->getMockBuilder('Magento\Eav\Model\Entity\Attribute\AbstractAttribute')
             ->disableOriginalConstructor()
             ->setMethods([
@@ -72,7 +70,7 @@ public function testGetClass()
         $attributeMock->expects($this->once())
             ->method('getFrontendClass')
             ->willReturn('');
-        $attributeMock->expects($this->exactly(2))
+        $attributeMock->expects($this->exactly(3))
             ->method('getValidateRules')
             ->willReturn([
                 'input_validation' => 'alphanumeric',

dev/tests/api-functional/testsuite/Magento/Customer/Api/CustomerMetadataTest.php

@@ -74,7 +74,7 @@ public function getAttributeMetadataDataProvider()
                     AttributeMetadata::REQUIRED         => true,
                     AttributeMetadata::DATA_MODEL       => '',
                     AttributeMetadata::OPTIONS          => [],
-                    AttributeMetadata::FRONTEND_CLASS   => ' required-entry',
+                    AttributeMetadata::FRONTEND_CLASS   => 'required-entry',
                     AttributeMetadata::USER_DEFINED     => false,
                     AttributeMetadata::SORT_ORDER       => 40,
                     AttributeMetadata::FRONTEND_LABEL   => 'First Name',
@@ -134,7 +134,7 @@ public function getAttributeMetadataDataProvider()
                     AttributeMetadata::OPTIONS          => [
                         ['label' => 'Main Website', 'value' => '1'],
                     ],
-                    AttributeMetadata::FRONTEND_CLASS   => ' required-entry',
+                    AttributeMetadata::FRONTEND_CLASS   => 'required-entry',
                     AttributeMetadata::USER_DEFINED     => false,
                     AttributeMetadata::SORT_ORDER       => 10,
                     AttributeMetadata::FRONTEND_LABEL   => 'Associate to Website',

dev/tests/integration/testsuite/Magento/Customer/Helper/AddressTest.php

@@ -30,9 +30,9 @@ public function getAttributeValidationClass()
     {
         return [
             ['bad-code', ''],
-            ['city', ' required-entry'],
+            ['city', 'required-entry'],
             ['company', ''],
-            ['country_id', ' required-entry'],
+            ['country_id', 'required-entry'],
             ['fax', ''],
             ['firstname', 'required-entry'],
             ['lastname', 'required-entry'],