ACP2E-55: Simple only global attributes make configurable attributes hidden when creating product configurations

 - Fixed the CR comments.

Author: devarul

app/code/Magento/ConfigurableProduct/Plugin/Model/UpdateConfigurableProductAttributeCollection.php

@@ -0,0 +1,88 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+
+namespace Magento\ConfigurableProduct\Test\Unit\Ui\DataProvider;
+
+use Magento\Catalog\Model\ResourceModel\Product\Attribute\Collection;
+use Magento\ConfigurableProduct\Model\ConfigurableAttributeHandler;
+use Magento\ConfigurableProduct\Ui\DataProvider\Attributes;
+use Magento\Framework\DataObject;
+use Magento\Framework\DB\Select;
+use Magento\Framework\TestFramework\Unit\Helper\ObjectManager;
+use PHPUnit\Framework\TestCase;
+
+class AttributesTest extends TestCase
+{
+    /**
+     * @var Collection
+     */
+    private Collection $collectionMock;
+
+    /**
+     * @var Select
+     */
+    private Select $selectMock;
+
+    /**
+     * @var Attributes
+     */
+    private Attributes $attributes;
+
+    /**
+     * @return void
+     */
+    protected function setUp(): void
+    {
+        $objectManager = new ObjectManager($this);
+        $this->collectionMock = $this->getMockBuilder(Collection::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+        $this->selectMock = $this->getMockBuilder(Select::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['where'])
+            ->getMock();
+        $collectionAttributeHandlerMock = $this->getMockBuilder(ConfigurableAttributeHandler::class)
+            ->disableOriginalConstructor()
+            ->onlyMethods(['getApplicableAttributes'])
+            ->getMock();
+        $collectionAttributeHandlerMock->expects($this->once())
+            ->method('getApplicableAttributes')
+            ->willReturn($this->collectionMock);
+        $this->attributes = $objectManager->getObject(
+            Attributes::class,
+            [
+                'name' => 'myName',
+                'primaryFieldName' => 'myPrimaryFieldName',
+                'requestFieldName' => 'myRequestFieldName',
+                'configurableAttributeHandler' => $collectionAttributeHandlerMock
+            ]
+        );
+    }
+
+    /**
+     * @return void
+     */
+    public function testGetData()
+    {
+        $expectedResult = [
+            'totalRecords' => 1,
+            'items' => [
+                0 => ['attribute' => 'color']
+            ]
+        ];
+        $this->collectionMock->expects($this->once())
+            ->method('getSelect')
+            ->willReturn($this->selectMock);
+        $this->collectionMock->expects($this->once())
+            ->method('getItems')
+            ->willReturn([new DataObject(['attribute' => 'color'])]);
+        $this->collectionMock->expects($this->once())
+            ->method('getSize')
+            ->willReturn(1);
+        $this->assertEquals($expectedResult, $this->attributes->getData());
+    }
+}

app/code/Magento/ConfigurableProduct/Test/Unit/Ui/DataProvider/AttributesTest.php

@@ -6,18 +6,16 @@
 
 namespace Magento\ConfigurableProduct\Ui\DataProvider;
 
+use Magento\Catalog\Model\Product\Type;
+use Magento\ConfigurableProduct\Model\Product\Type\Configurable;
+
 class Attributes extends \Magento\Ui\DataProvider\AbstractDataProvider
 {
     /**
      * @var \Magento\Catalog\Model\ResourceModel\Product\Attribute\Collection
      */
     protected $collection;
 
-    /**
-     * @var \Magento\ConfigurableProduct\Model\ConfigurableAttributeHandler
-     */
-    private $configurableAttributeHandler;
-
     /**
      * @param string $name
      * @param string $primaryFieldName
@@ -35,7 +33,6 @@ public function __construct(
         array $data = []
     ) {
         parent::__construct($name, $primaryFieldName, $requestFieldName, $meta, $data);
-        $this->configurableAttributeHandler = $configurableAttributeHandler;
         $this->collection = $configurableAttributeHandler->getApplicableAttributes();
     }
 
@@ -53,16 +50,28 @@ public function getCollection()
     public function getData()
     {
         $items = [];
-        $skippedItems = 0;
+        $this->getCollection()->getSelect()->where(
+            '(`apply_to` IS NULL) OR
+            (
+                FIND_IN_SET(' .
+            sprintf("'%s'", Type::TYPE_SIMPLE) . ',
+                    `apply_to`
+                ) AND
+                FIND_IN_SET(' .
+            sprintf("'%s'", Type::TYPE_VIRTUAL) . ',
+                    `apply_to`
+                ) AND
+                FIND_IN_SET(' .
+            sprintf("'%s'", Configurable::TYPE_CODE) . ',
+                    `apply_to`
+                )
+             )'
+        );
         foreach ($this->getCollection()->getItems() as $attribute) {
-            if ($this->configurableAttributeHandler->isAttributeApplicable($attribute)) {
-                $items[] = $attribute->toArray();
-            } else {
-                $skippedItems++;
-            }
+            $items[] = $attribute->toArray();
         }
         return [
-            'totalRecords' => $this->collection->getSize() - $skippedItems,
+            'totalRecords' => $this->collection->getSize(),
             'items' => $items
         ];
     }

app/code/Magento/ConfigurableProduct/Ui/DataProvider/Attributes.php

@@ -81,7 +81,4 @@
     <type name="Magento\Sales\Model\Order\Invoice">
         <plugin name="update_configurable_product_total_qty" type="Magento\ConfigurableProduct\Plugin\Model\Order\Invoice\UpdateConfigurableProductTotalQty"/>
     </type>
-    <type name="Magento\ConfigurableProduct\Ui\DataProvider\Attributes">
-        <plugin name="update_configurable_product_attribute_collection" type="Magento\ConfigurableProduct\Plugin\Model\UpdateConfigurableProductAttributeCollection"/>
-    </type>
 </config>