Skip to content

Commit cbf8a5d

Browse files
committed
MC-18478: Integrity constraint violation: 1452 Cannot add or update a child row: a foreign key constraint fails
1 parent 2980e38 commit cbf8a5d

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

app/code/Magento/Catalog/Model/Product/Compare/ListCompare.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public function addProduct($product)
9090
$this->_addVisitorToItem($item);
9191
$item->loadByProduct($product);
9292

93-
if (!$item->getId()) {
93+
if (!$item->getId() && $item->getProductId()) {
9494
$item->addProductData($product);
9595
$item->save();
9696
}

dev/tests/integration/testsuite/Magento/Catalog/Model/Product/Compare/ListCompareTest.php

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,25 @@ protected function tearDown()
4444
$this->_session->setCustomerId(null);
4545
}
4646

47+
/**
48+
* @magentoDataFixture Magento/Catalog/_files/second_product_simple.php
49+
*/
4750
public function testAddProductWithSession()
4851
{
4952
$this->_session->setCustomerId(1);
5053
/** @var $product \Magento\Catalog\Model\Product */
5154
$product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
5255
->create(\Magento\Catalog\Model\Product::class)
5356
->load(1);
54-
$this->_model->addProduct($product);
57+
/** @var $product2 \Magento\Catalog\Model\Product */
58+
$product2 = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
59+
->create(\Magento\Catalog\Model\Product::class)
60+
->load(6);
61+
$this->_model->addProducts([$product->getId(), $product2->getId(), 'none', 99]);
5562
$this->assertTrue($this->_model->hasItems(1, $this->_visitor->getId()));
63+
$this->assertTrue($this->_model->hasItems(6, $this->_visitor->getId()));
64+
$this->assertFalse($this->_model->hasItems('none', $this->_visitor->getId()));
65+
$this->assertFalse($this->_model->hasItems(99, $this->_visitor->getId()));
5666
}
5767

5868
public function testAddProductWithoutSession()

0 commit comments

Comments
 (0)