Skip to content

Commit cbb822b

Browse files
Joan HeMaksym Savich
Joan He
authored and
Maksym Savich
committed
MAGETWO-32012: DB timestamp columns with on update current_timestamp aren't handled correctly
(cherry picked from commit 1922fac)
1 parent 569b0d6 commit cbb822b

File tree

13 files changed

+29
-29
lines changed

13 files changed

+29
-29
lines changed

‎app/code/Magento/AdminNotification/Setup/InstallSchema.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
4545
'date_added',
4646
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
4747
null,
48-
['nullable' => false],
48+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
4949
'Create date'
5050
)->addColumn(
5151
'title',
@@ -112,7 +112,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
112112
'created_at',
113113
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
114114
null,
115-
['nullable' => false],
115+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
116116
'Create date'
117117
)->setComment(
118118
'Admin System Messages'

‎app/code/Magento/Cron/Setup/InstallSchema.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
5757
'created_at',
5858
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
5959
null,
60-
['nullable' => false],
60+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
6161
'Created At'
6262
)->addColumn(
6363
'scheduled_at',

‎app/code/Magento/Customer/Setup/InstallSchema.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,13 +81,13 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
8181
'created_at',
8282
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
8383
null,
84-
['nullable' => false],
84+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
8585
'Created At'
8686
)->addColumn(
8787
'updated_at',
8888
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
8989
null,
90-
['nullable' => false],
90+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_UPDATE],
9191
'Updated At'
9292
)->addColumn(
9393
'is_active',
@@ -176,13 +176,13 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
176176
'created_at',
177177
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
178178
null,
179-
['nullable' => false],
179+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
180180
'Created At'
181181
)->addColumn(
182182
'updated_at',
183183
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
184184
null,
185-
['nullable' => false],
185+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_UPDATE],
186186
'Updated At'
187187
)->addColumn(
188188
'is_active',

‎app/code/Magento/Downloadable/Setup/InstallSchema.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -219,14 +219,14 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
219219
'created_at',
220220
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
221221
null,
222-
['nullable' => false],
222+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
223223
'Date of creation'
224224
)
225225
->addColumn(
226226
'updated_at',
227227
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
228228
null,
229-
['nullable' => false],
229+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_UPDATE],
230230
'Date of modification'
231231
)
232232
->addColumn(
@@ -395,14 +395,14 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
395395
'created_at',
396396
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
397397
null,
398-
['nullable' => false],
398+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
399399
'Creation Time'
400400
)
401401
->addColumn(
402402
'updated_at',
403403
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
404404
null,
405-
['nullable' => false],
405+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_UPDATE],
406406
'Update Time'
407407
)
408408
->addIndex(

‎app/code/Magento/Eav/Setup/InstallSchema.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,13 +179,13 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
179179
'created_at',
180180
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
181181
null,
182-
['nullable' => false],
182+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
183183
'Created At'
184184
)->addColumn(
185185
'updated_at',
186186
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
187187
null,
188-
['nullable' => false],
188+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_UPDATE],
189189
'Updated At'
190190
)->addColumn(
191191
'is_active',

‎app/code/Magento/Integration/Setup/InstallSchema.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,13 +320,13 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
320320
'created_at',
321321
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
322322
null,
323-
['nullable' => false],
323+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
324324
'Creation Time'
325325
)->addColumn(
326326
'updated_at',
327327
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
328328
null,
329-
['nullable' => false],
329+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_UPDATE],
330330
'Update Time'
331331
)->addColumn(
332332
'setup_type',

‎app/code/Magento/Log/Setup/InstallSchema.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
9595
'created_at',
9696
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
9797
null,
98-
['nullable' => false],
98+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
9999
'Creation Time'
100100
)->addColumn(
101101
'deleted_at',
@@ -147,7 +147,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
147147
'add_date',
148148
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
149149
null,
150-
['nullable' => false],
150+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
151151
'Date'
152152
)->setComment(
153153
'Log Summary Table'

‎app/code/Magento/ProductAlert/Setup/InstallSchema.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
6363
'add_date',
6464
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
6565
null,
66-
['nullable' => false],
66+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
6767
'Product alert add date'
6868
)->addColumn(
6969
'last_send_date',
@@ -151,7 +151,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
151151
'add_date',
152152
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
153153
null,
154-
['nullable' => false],
154+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
155155
'Product alert add date'
156156
)->addColumn(
157157
'send_date',

‎app/code/Magento/Reports/Setup/InstallSchema.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
7373
'added_at',
7474
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
7575
null,
76-
['nullable' => false],
76+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
7777
'Added At'
7878
)
7979
->addIndex(
@@ -184,7 +184,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
184184
'added_at',
185185
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
186186
null,
187-
['nullable' => false],
187+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
188188
'Added At'
189189
)
190190
->addIndex(
@@ -294,7 +294,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
294294
'logged_at',
295295
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
296296
null,
297-
['nullable' => false],
297+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
298298
'Logged At'
299299
)
300300
->addColumn(
@@ -419,7 +419,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
419419
'added_at',
420420
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
421421
null,
422-
['nullable' => false],
422+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
423423
'Added At'
424424
)
425425
->addIndex(
@@ -528,7 +528,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
528528
'added_at',
529529
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
530530
null,
531-
['nullable' => false],
531+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
532532
'Added At'
533533
)
534534
->addIndex(

‎app/code/Magento/Review/Setup/InstallSchema.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ public function install(SchemaSetupInterface $setup, ModuleContextInterface $con
8484
'created_at',
8585
\Magento\Framework\DB\Ddl\Table::TYPE_TIMESTAMP,
8686
null,
87-
['nullable' => false],
87+
['nullable' => false, 'default' => \Magento\Framework\DB\Ddl\Table::TIMESTAMP_INIT],
8888
'Review create date'
8989
)
9090
->addColumn(

0 commit comments

Comments
 (0)