Merge remote-tracking branch 'origin/BUG#AC-7632' into spartans_pr_13062023

Author: glo80326

app/code/Magento/Sales/Model/Order/Creditmemo.php

@@ -563,6 +563,10 @@ public function isLast()
     {
         $items = $this->getAllItems();
         foreach ($items as $item) {
+            if ($item->getOrderItem()->isDummy()) {
+                continue;
+            }
+
             if (!$item->isLast()) {
                 return false;
             }

app/code/Magento/Sales/Test/Unit/Model/Order/CreditmemoTest.php

@@ -20,6 +20,7 @@
 use Magento\Sales\Model\Order\Creditmemo\CommentFactory;
 use Magento\Sales\Model\Order\Creditmemo\Config;
 use Magento\Sales\Model\Order\Creditmemo\Item;
+use Magento\Sales\Model\Order\Item as OrderItem;
 use Magento\Sales\Model\ResourceModel\Order\Creditmemo\Item\Collection as ItemCollection;
 use Magento\Sales\Model\ResourceModel\Order\Creditmemo\Item\CollectionFactory;
 use Magento\Store\Model\StoreManagerInterface;
@@ -201,4 +202,40 @@ public function testGetItemsCollectionWithoutId()
         $itemsCollection = $this->creditmemo->getItemsCollection();
         $this->assertEquals($items, $itemsCollection);
     }
+
+    public function testIsLastForLastCreditMemo(): void
+    {
+        $item = $this->getMockBuilder(Item::class)->disableOriginalConstructor()->getMock();
+        $orderItem = $this->getMockBuilder(OrderItem::class)->disableOriginalConstructor()->getMock();
+        $orderItem
+            ->expects($this->once())
+            ->method('isDummy')
+            ->willReturn(true);
+        $item->expects($this->once())
+            ->method('getOrderItem')
+            ->willReturn($orderItem);
+        $this->creditmemo->setItems([$item]);
+        $this->assertTrue($this->creditmemo->isLast());
+    }
+
+    public function testIsLastForNonLastCreditMemo(): void
+    {
+        $item = $this->getMockBuilder(Item::class)->disableOriginalConstructor()->getMock();
+        $orderItem = $this->getMockBuilder(OrderItem::class)->disableOriginalConstructor()->getMock();
+        $orderItem
+            ->expects($this->once())
+            ->method('isDummy')
+            ->willReturn(false);
+        $item->expects($this->once())
+            ->method('getOrderItem')
+            ->willReturn($orderItem);
+        $item->expects($this->once())
+            ->method('getOrderItem')
+            ->willReturn($orderItem);
+        $item->expects($this->once())
+            ->method('isLast')
+            ->willReturn(false);
+        $this->creditmemo->setItems([$item]);
+        $this->assertFalse($this->creditmemo->isLast());
+    }
 }