Skip to content

Commit cb4e2bb

Browse files
committed
MAGETWO-52000: impossible to see what is wrong with cron - unhelpful error message
- code updates to fix QA issues and review comments
1 parent c6f7ea0 commit cb4e2bb

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

setup/src/Magento/Setup/Console/Command/CronRunCommand.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,6 @@ protected function execute(InputInterface $input, OutputInterface $output)
7979
if (!$this->deploymentConfig->isAvailable()) {
8080
$output->writeln($notification);
8181
$this->status->add('Magento is not installed.', \Psr\Log\LogLevel::INFO);
82-
83-
// we must have an exit code higher than zero to indicate something was wrong
8482
return \Magento\Framework\Console\Cli::RETURN_SUCCESS;
8583
}
8684

setup/src/Magento/Setup/Model/Cron/SetupStreamHandler.php

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
namespace Magento\Setup\Model\Cron;
88

9-
use Monolog\Handler\StreamHandler;
9+
use Magento\Framework\Filesystem\DriverInterface;
1010

1111
/**
1212
* Setup specific stream handler
@@ -22,4 +22,15 @@ class SetupStreamHandler extends \Magento\Framework\Logger\Handler\Base
2222
* @var int
2323
*/
2424
protected $loggerType = \Magento\Framework\Logger\Monolog::ERROR;
25+
26+
/**
27+
* @param DriverInterface $filesystem
28+
* @param string $filePath
29+
*/
30+
public function __construct(
31+
DriverInterface $filesystem,
32+
$filePath = null
33+
) {
34+
parent::__construct($filesystem, $filePath);
35+
}
2536
}

0 commit comments

Comments
 (0)