MAGETWO-81034: API for fetching multiple products

- static fixes

Author: cpartica

app/code/Magento/GraphQl/Model/GraphQl/Clause/ReferenceTypeFactory.php

@@ -27,7 +27,7 @@ public function __construct(
     }
 
     /**
-     * Creates a ReferenceType
+     * Create ReferenceType
      *
      * @param string $entityType
      * @param string|null $linkField

app/code/Magento/GraphQl/Model/GraphQl/ClauseFactory.php

@@ -28,7 +28,7 @@ public function __construct(
     }
 
     /**
-     * Creates a clause
+     * Create a clause
      *
      * @param ReferenceType $referenceType
      * @param string $fieldName

app/code/Magento/GraphQl/Model/GraphQl/ConnectiveFactory.php

@@ -26,7 +26,7 @@ public function __construct(
         $this->objectManager = $objectManager;
     }
     /**
-     * Creates a connective class
+     * Create a connective class
      *
      * @param array $conditions
      * @param string|null $operator

app/code/Magento/GraphQl/Model/GraphQl/Operator.php

@@ -5,6 +5,9 @@
  */
 namespace Magento\GraphQl\Model\GraphQl;
 
+/**
+ * Class Operator
+ */
 class Operator
 {
     /**

app/code/Magento/GraphQl/Model/Resolver/Product.php

@@ -72,7 +72,7 @@ public function resolve(array $args, ResolveInfo $info)
     }
 
     /**
-     * Resolves product by Sku
+     * Resolve product by Sku
      *
      * @param string $sku
      * @return array|null
@@ -89,7 +89,7 @@ public function getProduct(string $sku)
     }
 
     /**
-     * Resolves product by Id
+     * Resolve product by Id
      *
      * @param int $productId
      * @return array|null

app/code/Magento/GraphQl/Model/Resolver/Products.php

@@ -9,9 +9,10 @@
 use Magento\Catalog\Api\ProductRepositoryInterface;
 use GraphQL\Type\Definition\ResolveInfo;
 use Magento\GraphQl\Model\ResolverInterface;
+use Magento\GraphQl\Model\Resolver\Products\SearchCriteriaFactory;
 
 /**
- * Product field resolver, used for GraphQL request processing.
+ * Products field resolver, used for GraphQL request processing.
  */
 class Products implements ResolverInterface
 {
@@ -20,7 +21,7 @@ class Products implements ResolverInterface
      */
     private $productRepository;
 
-    /** @var \Magento\GraphQl\Model\Resolver\Products\SearchCriteriaFactory */
+    /** @var SearchCriteriaFactory */
     private $searchCriteriaFactory;
 
     /**
@@ -54,7 +55,7 @@ public function resolve(array $args, ResolveInfo $info)
         }
 
         $maxPages = ceil($itemsResults->getTotalCount() / $searchCriteria->getPageSize());
-        if ($searchCriteria->getCurrentPage() > $maxPages) {
+        if ($searchCriteria->getCurrentPage() > $maxPages && $itemsResults->getTotalCount() > 0) {
             throw new \GraphQL\Error\Error(sprintf('Current page is bigger than maximum %s', $maxPages));
         }
 

app/code/Magento/GraphQl/Model/Resolver/Products/FilterGroupFactory.php

@@ -10,19 +10,21 @@
 use Magento\GraphQl\Model\GraphQl\Clause;
 use Magento\GraphQl\Model\GraphQl\Connective;
 use Magento\GraphQl\Model\GraphQl\Operator;
+use Magento\Framework\Api\FilterBuilder;
+use Magento\Framework\Api\Search\FilterGroupBuilder;
 
 /**
- * Product field resolver, used for GraphQL request processing.
+ * Class FilterGroupFactory
  */
 class FilterGroupFactory
 {
-    /** @var \Magento\Framework\Api\FilterBuilder */
+    /** @var FilterBuilder */
     private $filterBuilder;
 
-    /** @var \Magento\Framework\Api\Search\FilterGroupBuilder */
+    /** @var FilterGroupBuilder */
     private $filterGroupBuilder;
 
-    /** @var \Magento\GraphQl\Model\Resolver\Products\ProductFilterResolver */
+    /** @var ProductFilterResolver */
     private $filterResolver;
 
     /**
@@ -41,7 +43,7 @@ public function __construct(
     }
 
     /**
-     * Creates a filter groups from an AST
+     * Create a filter groups from an AST
      *
      * @param ResolveInfo $info
      * @return \Magento\Framework\Api\Search\FilterGroup[]
@@ -88,7 +90,7 @@ public function create(ResolveInfo $info)
     }
 
     /**
-     * Processes an AST Connective
+     * Process an AST Connective
      *
      * @param Connective $connective
      * @return \Magento\Framework\Api\Search\FilterGroup
@@ -114,7 +116,7 @@ private function processConnective(Connective $connective)
     }
 
     /**
-     * Processes an AST Clause
+     * Process an AST Clause
      *
      * @param Clause $clause
      * @return \Magento\Framework\Api\Search\FilterGroup

app/code/Magento/GraphQl/Model/Resolver/Products/ProductFilterResolver.php

@@ -17,7 +17,7 @@
 use Magento\GraphQl\Model\Type\Helper\ServiceContract\TypeGenerator;
 
 /**
- * Class Product FilterResolver
+ * Product field resolver, used for GraphQL request processing
  */
 class ProductFilterResolver
 {
@@ -68,7 +68,7 @@ public function __construct(
     }
 
     /**
-     * Gets a clause from an AST
+     * Get a clause from an AST
      *
      * @param ReferenceType $referenceType
      * @param NodeList $nodeList
@@ -109,7 +109,7 @@ private function getClausesFromAst(ReferenceType $referenceType, NodeList $nodeL
     }
 
     /**
-     * Gets the fields from catalog product
+     * Get the fields from catalog product
      *
      * @return array
      */
@@ -135,7 +135,7 @@ private function getCatalogProductFields()
     }
 
     /**
-     * Gets a connective filter from an AST
+     * Get a connective filter from an AST
      *
      * @param string $entityType
      * @param SelectionNode $node

app/code/Magento/GraphQl/Model/Resolver/Products/SearchCriteriaFactory.php

@@ -9,15 +9,16 @@
 use Magento\Framework\Api\SortOrder;
 use Magento\Framework\Api\SortOrderBuilder;
 use GraphQL\Type\Definition\ResolveInfo;
+use Magento\Framework\Api\SearchCriteriaInterfaceFactory;
 
 /**
- * Product field resolver, used for GraphQL request processing.
+ * Create a search criteria from AST.
  */
 class SearchCriteriaFactory
 {
     const DEFAULT_PAGE_SIZE = 20;
 
-    /** @var \Magento\Framework\Api\SearchCriteriaInterfaceFactory */
+    /** @var SearchCriteriaInterfaceFactory */
     private $searchCriteriaFactory;
 
     /** @var SortOrderBuilder */
@@ -42,7 +43,7 @@ public function __construct(
     }
 
     /**
-     * Creates a search criteria from an AST
+     * Create a search criteria from an AST method
      *
      * @param ResolveInfo $info
      * @return \Magento\Framework\Api\SearchCriteriaInterface

app/code/Magento/GraphQl/Model/SchemaGenerator.php

@@ -13,7 +13,7 @@
 use Magento\GraphQl\Model\ResolverFactory;
 
 /**
- * Generates query field and concrete types for GraphQL scehma
+ * Generate a query field and concrete types for GraphQL schema
  */
 class SchemaGenerator implements SchemaGeneratorInterface
 {