Skip to content

Commit cad441e

Browse files
author
Oleksandr Gorkun
committed
MAGETWO-56445: Eliminate @escapeNotVerified in Google-related Modules
1 parent 353322d commit cad441e

File tree

2 files changed

+12
-12
lines changed
  • app/code/Magento
    • GoogleAdwords/view/frontend/templates
    • GoogleAnalytics/view/frontend/templates

2 files changed

+12
-12
lines changed

app/code/Magento/GoogleAdwords/view/frontend/templates/code.phtml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,22 +12,22 @@
1212
<!-- Google Code for Sale Conversion Page -->
1313
<script>
1414
/* <![CDATA[ */
15-
var google_conversion_id = <?= /* @escapeNotVerified */ $block->getHelper()->getConversionId() ?>;
16-
var google_conversion_language = "<?= /* @escapeNotVerified */ $block->getHelper()->getConversionLanguage() ?>";
17-
var google_conversion_format = "<?= /* @escapeNotVerified */ $block->getHelper()->getConversionFormat() ?>";
18-
var google_conversion_color = "<?= /* @escapeNotVerified */ $block->getHelper()->getConversionColor() ?>";
19-
var google_conversion_label = "<?= /* @escapeNotVerified */ $block->getHelper()->getConversionLabel() ?>";
20-
var google_conversion_value = <?= /* @escapeNotVerified */ $block->getHelper()->getConversionValue() ?>;
15+
var google_conversion_id = <?= $block->escapeJs($block->getHelper()->getConversionId()) ?>;
16+
var google_conversion_language = "<?= $block->escapeJs($block->getHelper()->getConversionLanguage()) ?>";
17+
var google_conversion_format = "<?= $block->escapeJs($block->getHelper()->getConversionFormat()) ?>";
18+
var google_conversion_color = "<?= $block->escapeJs($block->getHelper()->getConversionColor()) ?>";
19+
var google_conversion_label = "<?= $block->escapeJs($block->getHelper()->getConversionLabel()) ?>";
20+
var google_conversion_value = <?= $block->escapeJs($block->getHelper()->getConversionValue()) ?>;
2121
<?php if($block->getHelper()->hasSendConversionValueCurrency() && $block->getHelper()->getConversionValueCurrency()): ?>
22-
var google_conversion_currency = "<?= /* @escapeNotVerified */ $block->getHelper()->getConversionValueCurrency() ?>";
22+
var google_conversion_currency = "<?= $block->escapeJs($block->getHelper()->getConversionValueCurrency()) ?>";
2323
<?php endif; ?>
2424
/* ]]> */
2525
</script>
26-
<script src="<?= /* @escapeNotVerified */ $block->getHelper()->getConversionJsSrc() ?>"></script>
26+
<script src="<?= $block->escapeHtmlAttr($block->getHelper()->getConversionJsSrc()) ?>"></script>
2727
<noscript>
2828
<div style="display:inline;">
2929
<img height="1" width="1" style="border-style:none;" alt=""
30-
src="<?= /* @escapeNotVerified */ $block->getHelper()->getConversionImgSrc() ?>"/>
30+
src="<?= $block->escapeHtmlAttr($block->getHelper()->getConversionImgSrc()) ?>"/>
3131
</div>
3232
</noscript>
3333
<!-- END Google Code for Sale Conversion Page -->

app/code/Magento/GoogleAnalytics/view/frontend/templates/ga.phtml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
"Magento_GoogleAnalytics/js/google-analytics": {
1717
"isCookieRestrictionModeEnabled": <?= (int)$block->isCookieRestrictionModeEnabled() ?>,
1818
"currentWebsite": <?= (int)$block->getCurrentWebsiteId() ?>,
19-
"cookieName": "<?= /* @escapeNotVerified */ \Magento\Cookie\Helper\Cookie::IS_USER_ALLOWED_SAVE_COOKIE ?>",
20-
"ordersTrackingData": <?= /* @escapeNotVerified */ json_encode($block->getOrdersTrackingData()) ?>,
21-
"pageTrackingData": <?= /* @escapeNotVerified */ json_encode($block->getPageTrackingData($accountId)) ?>
19+
"cookieName": "<?= /* @noEscape */ \Magento\Cookie\Helper\Cookie::IS_USER_ALLOWED_SAVE_COOKIE ?>",
20+
"ordersTrackingData": <?= /* @noEscape */ json_encode($block->getOrdersTrackingData()) ?>,
21+
"pageTrackingData": <?= /* @noEscape */ json_encode($block->getPageTrackingData($accountId)) ?>
2222
}
2323
}
2424
}

0 commit comments

Comments
 (0)