Merge branch '2.2-develop_SPRINT-41_V1' into 'SPRINT-41'

2.2 develop sprint 41 v1

See merge request !274

Author: isxam

app/code/Magento/Backend/Block/Template.php

@@ -85,12 +85,22 @@ public function getFormKey()
      *
      * @param string $moduleName Full module name
      * @return boolean
-     * @deprecated 100.2.0 Magento does not support custom disabling/enabling module output since 2.2.0 version
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
+     * @deprecated 100.2.0 Magento does not support disabling/enabling modules output from the Admin Panel since 2.2.0
+     * version. Module output can still be enabled/disabled in configuration files. However, this functionality should
+     * not be used in future development. Module design should explicitly state dependencies to avoid requiring output
+     * disabling. This functionality will temporarily be kept in Magento core, as there are unresolved modularity
+     * issues that will be addressed in future releases.
      */
     public function isOutputEnabled($moduleName = null)
     {
-        return true;
+        if ($moduleName === null) {
+            $moduleName = $this->getModuleName();
+        }
+
+        return !$this->_scopeConfig->isSetFlag(
+            'advanced/modules_disable_output/' . $moduleName,
+            \Magento\Store\Model\ScopeInterface::SCOPE_STORE
+        );
     }
 
     /**

app/code/Magento/Bundle/etc/di.xml

@@ -160,6 +160,9 @@
             <argument name="estimators" xsi:type="array">
                 <item name="bundle" xsi:type="object">Magento\Catalog\Model\Indexer\Price\CompositeProductBatchSizeManagement</item>
             </argument>
+            <argument name="batchSizeAdjusters" xsi:type="array">
+                <item name="bundle" xsi:type="object">Magento\Catalog\Model\ResourceModel\Product\Indexer\Price\CompositeProductBatchSizeAdjuster</item>
+            </argument>
         </arguments>
     </type>
     <type name="Magento\Bundle\Model\ResourceModel\Indexer\Price">

app/code/Magento/Catalog/Model/Indexer/Product/Price/Action/Full.php

@@ -106,6 +106,9 @@ public function execute($ids = null)
                 $this->_defaultIndexerResource->getMainTable()
             );
 
+            // Prepare replica table for indexation.
+            $this->_defaultIndexerResource->getConnection()->truncateTable($replicaTable);
+
             /** @var \Magento\Catalog\Model\ResourceModel\Product\Indexer\AbstractIndexer $indexer */
             foreach ($this->getTypeIndexers() as $indexer) {
                 $indexer->getTableStrategy()->setUseIdxTable(false);

app/code/Magento/Catalog/Model/ResourceModel/Product/Indexer/Price/BatchSizeCalculator.php

@@ -21,15 +21,24 @@ class BatchSizeCalculator
      */
     private $estimators;
 
+    /**
+     * @var \Magento\Catalog\Model\ResourceModel\Product\Indexer\Price\CompositeProductBatchSizeAdjusterInterface[]
+     * @since 2.2.0
+     */
+    private $batchSizeAdjusters;
+
     /**
      * BatchSizeCalculator constructor.
      * @param array $batchRowsCount
      * @param array $estimators
+     * @param array $batchSizeAdjusters
+     * @since 2.2.0
      */
-    public function __construct(array $batchRowsCount, array $estimators)
+    public function __construct(array $batchRowsCount, array $estimators, array $batchSizeAdjusters)
     {
         $this->batchRowsCount = $batchRowsCount;
         $this->estimators = $estimators;
+        $this->batchSizeAdjusters = $batchSizeAdjusters;
     }
 
     /**
@@ -52,6 +61,10 @@ public function estimateBatchSize(\Magento\Framework\DB\Adapter\AdapterInterface
             ? $this->estimators[$indexerTypeId]
             : $this->estimators['default'];
 
+        $batchRowsCount = isset($this->batchSizeAdjusters[$indexerTypeId])
+            ? $this->batchSizeAdjusters[$indexerTypeId]->adjust($batchRowsCount)
+            : $batchRowsCount;
+
         $calculator->ensureBatchSize($connection, $batchRowsCount);
 
         return $batchRowsCount;

app/code/Magento/Catalog/Model/ResourceModel/Product/Indexer/Price/CompositeProductBatchSizeAdjuster.php

@@ -0,0 +1,35 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Catalog\Model\ResourceModel\Product\Indexer\Price;
+
+/**
+ * Correct batch size according to number of composite related items.
+ */
+class CompositeProductBatchSizeAdjuster implements CompositeProductBatchSizeAdjusterInterface
+{
+    /**
+     * @var CompositeProductRelationsCalculator
+     */
+    private $compositeProductRelationsCalculator;
+
+    /**
+     * @param CompositeProductRelationsCalculator $compositeProductRelationsCalculator
+     */
+    public function __construct(CompositeProductRelationsCalculator $compositeProductRelationsCalculator)
+    {
+        $this->compositeProductRelationsCalculator = $compositeProductRelationsCalculator;
+    }
+
+    /**
+     * {@inheritdoc}
+     */
+    public function adjust($batchSize)
+    {
+        $maxRelationsCount = $this->compositeProductRelationsCalculator->getMaxRelationsCount();
+        return $maxRelationsCount > 0 ? ceil($batchSize / $maxRelationsCount) : $batchSize;
+    }
+}

app/code/Magento/Catalog/Model/ResourceModel/Product/Indexer/Price/CompositeProductBatchSizeAdjusterInterface.php

@@ -0,0 +1,22 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Catalog\Model\ResourceModel\Product\Indexer\Price;
+
+/**
+ * Correct batch size according to number of composite related items.
+ * @api
+ */
+interface CompositeProductBatchSizeAdjusterInterface
+{
+    /**
+     * Correct batch size according to number of composite related items.
+     *
+     * @param int $batchSize
+     * @return int
+     */
+    public function adjust($batchSize);
+}

app/code/Magento/Catalog/Model/ResourceModel/Product/Indexer/Price/CompositeProductRelationsCalculator.php

@@ -0,0 +1,44 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+namespace Magento\Catalog\Model\ResourceModel\Product\Indexer\Price;
+
+/**
+ * Class calculates composite product relations.
+ */
+class CompositeProductRelationsCalculator
+{
+    /**
+     * @param DefaultPrice $indexerResource
+     */
+    public function __construct(DefaultPrice $indexerResource)
+    {
+        $this->indexerResource = $indexerResource;
+    }
+
+    /**
+     * Returns maximum number of composite related products.
+     *
+     * @return int
+     */
+    public function getMaxRelationsCount()
+    {
+        $connection = $this->indexerResource->getConnection();
+        $relationSelect = $connection->select();
+        $relationSelect->from(
+            ['relation' => $this->indexerResource->getTable('catalog_product_relation')],
+            ['count' => new \Zend_Db_Expr('count(relation.child_id)')]
+        );
+        $relationSelect->group('parent_id');
+
+        $maxSelect = $connection->select();
+        $maxSelect->from(
+            ['max_value' => $relationSelect],
+            ['count' => new \Zend_Db_Expr('MAX(count)')]
+        );
+        return $connection->fetchOne($maxSelect);
+    }
+}

app/code/Magento/Catalog/Model/ResourceModel/Product/Indexer/Price/CompositeProductRowSizeEstimator.php

@@ -20,11 +20,6 @@ class CompositeProductRowSizeEstimator implements IndexTableRowSizeEstimatorInte
      */
     const MEMORY_SIZE_FOR_ONE_ROW = 200;
 
-    /**
-     * @var DefaultPrice
-     */
-    private $indexerResource;
-
     /**
      * @var WebsiteManagementInterface
      */
@@ -36,18 +31,25 @@ class CompositeProductRowSizeEstimator implements IndexTableRowSizeEstimatorInte
     private $collectionFactory;
 
     /**
-     * @param DefaultPrice $indexerResource
+     * @var CompositeProductRelationsCalculator
+     * @since 2.2.0
+     */
+    private $compositeProductRelationsCalculator;
+
+    /**
      * @param WebsiteManagementInterface $websiteManagement
      * @param CollectionFactory $collectionFactory
+     * @param CompositeProductRelationsCalculator $compositeProductRelationsCalculator
+     * @since 2.2.0
      */
     public function __construct(
-        DefaultPrice $indexerResource,
         WebsiteManagementInterface $websiteManagement,
-        CollectionFactory $collectionFactory
+        CollectionFactory $collectionFactory,
+        CompositeProductRelationsCalculator $compositeProductRelationsCalculator
     ) {
-        $this->indexerResource = $indexerResource;
         $this->websiteManagement = $websiteManagement;
         $this->collectionFactory = $collectionFactory;
+        $this->compositeProductRelationsCalculator = $compositeProductRelationsCalculator;
     }
 
     /**
@@ -59,21 +61,7 @@ public function estimateRowSize()
     {
         $websitesCount = $this->websiteManagement->getCount();
         $customerGroupCount = $this->collectionFactory->create()->getSize();
-
-        $connection = $this->indexerResource->getConnection();
-        $relationSelect = $connection->select();
-        $relationSelect->from(
-            ['relation' => $this->indexerResource->getTable('catalog_product_relation')],
-            ['count' => new \Zend_Db_Expr('count(relation.child_id)')]
-        );
-        $relationSelect->group('parent_id');
-
-        $maxSelect = $connection->select();
-        $maxSelect->from(
-            ['max_value' => $relationSelect],
-            ['count' => new \Zend_Db_Expr('MAX(count)')]
-        );
-        $maxRelatedProductCount = $connection->fetchOne($maxSelect);
+        $maxRelatedProductCount = $this->compositeProductRelationsCalculator->getMaxRelationsCount();
 
         /**
          * Calculate memory size for largest composite product in database.

app/code/Magento/Catalog/Test/Unit/Block/Adminhtml/Product/Options/AjaxTest.php

@@ -58,6 +58,12 @@ public function testToHtml()
             ->getMock();
         $eventManager->expects($this->exactly(2))->method('dispatch')->will($this->returnValue(true));
 
+        $scopeConfig = $this->getMockBuilder(\Magento\Framework\App\Config::class)
+            ->setMethods(['getValue'])
+            ->disableOriginalConstructor()->getMock();
+        $scopeConfig->expects($this->once())->method('getValue')->withAnyParameters()
+            ->will($this->returnValue(false));
+
         $product = $this->getMockBuilder(\Magento\Catalog\Model\Product::class)->disableOriginalConstructor()
             ->setMethods(['setStoreId', 'load', 'getId', '__wakeup', '__sleep'])
             ->getMock();
@@ -90,6 +96,8 @@ public function testToHtml()
 
         $this->context->expects($this->once())->method('getEventManager')
             ->will($this->returnValue($eventManager));
+        $this->context->expects($this->once())->method('getScopeConfig')
+            ->will($this->returnValue($scopeConfig));
         $this->context->expects($this->once())->method('getLayout')
             ->will($this->returnValue($layout));
         $this->context->expects($this->once())->method('getRequest')

app/code/Magento/Catalog/Test/Unit/Block/Product/Widget/NewWidgetTest.php

@@ -186,6 +186,8 @@ protected function generalGetProductCollection()
     {
         $this->eventManager->expects($this->exactly(2))->method('dispatch')
             ->will($this->returnValue(true));
+        $this->scopeConfig->expects($this->once())->method('getValue')->withAnyParameters()
+            ->willReturn(false);
         $this->cacheState->expects($this->atLeastOnce())->method('isEnabled')->withAnyParameters()
             ->willReturn(false);
         $this->catalogConfig->expects($this->once())->method('getProductAttributes')