Skip to content

Commit ca4282e

Browse files
committed
Add RETURN_FAILURED return if things fail
1 parent 047097b commit ca4282e

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

setup/src/Magento/Setup/Console/Command/ModuleStatusCommand.php

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
use Magento\Framework\Module\FullModuleList;
1212
use Magento\Framework\Module\ModuleList;
1313
use Magento\Setup\Model\ObjectManagerProvider;
14+
use Magento\Framework\Console\Cli;
1415
use Symfony\Component\Console\Input\InputInterface;
1516
use Symfony\Component\Console\Output\OutputInterface;
1617
use Symfony\Component\Console\Input\InputArgument;
@@ -89,13 +90,13 @@ private function showSpecificModule(string $moduleName, OutputInterface $output)
8990
$allModules = $this->getAllModules();
9091
if (!in_array($moduleName, $allModules->getNames())) {
9192
$output->writeln('<error>Module does not exist</error>');
92-
return;
93+
return Cli::RETURN_FAILURE;
9394
}
9495

9596
$enabledModules = $this->getEnabledModules();
9697
if (in_array($moduleName, $enabledModules->getNames())) {
9798
$output->writeln('<info>Module is enabled</info>');
98-
return;
99+
return Cli::RETURN_FAILURE;
99100
}
100101

101102
$output->writeln('<info>Module is disabled</info>');
@@ -110,9 +111,10 @@ private function showEnabledModules(OutputInterface $output)
110111
$enabledModuleNames = $enabledModules->getNames();
111112
if (count($enabledModuleNames) === 0) {
112113
$output->writeln('None');
113-
} else {
114-
$output->writeln(join("\n", $enabledModuleNames));
114+
return Cli::RETURN_FAILURE;
115115
}
116+
117+
$output->writeln(join("\n", $enabledModuleNames));
116118
}
117119

118120
/**
@@ -123,9 +125,10 @@ private function showDisabledModules(OutputInterface $output)
123125
$disabledModuleNames = $this->getDisabledModuleNames();
124126
if (count($disabledModuleNames) === 0) {
125127
$output->writeln('None');
126-
} else {
127-
$output->writeln(join("\n", $disabledModuleNames));
128+
return Cli::RETURN_FAILURE;
128129
}
130+
131+
$output->writeln(join("\n", $disabledModuleNames));
129132
}
130133

131134
/**

0 commit comments

Comments
 (0)