MAGETWO-50831: Impossible specify Bundle option title on store view level

Author: OlgaVasyltsun

app/code/Magento/Bundle/Model/Product/SaveHandler.php

@@ -139,14 +139,12 @@ private function getOptionIds(array $options): array
     {
         $optionIds = [];
 
-        if (empty($options)) {
-            return $optionIds;
-        }
-
-        /** @var \Magento\Bundle\Api\Data\OptionInterface $option */
-        foreach ($options as $option) {
-            if ($option->getOptionId()) {
-                $optionIds[] = $option->getOptionId();
+        if (!empty($options)) {
+            /** @var \Magento\Bundle\Api\Data\OptionInterface $option */
+            foreach ($options as $option) {
+                if ($option->getOptionId()) {
+                    $optionIds[] = $option->getOptionId();
+                }
             }
         }
 

dev/tests/integration/testsuite/Magento/Bundle/Model/Product/SaveHandlerTest.php

@@ -46,7 +46,10 @@ protected function setUp()
         $this->productRepository = $this->objectManager->create(ProductRepositoryInterface::class);
     }
 
-    public function testOptionTitlesOnDifferentStores()
+    /**
+     * @return void
+     */
+    public function testOptionTitlesOnDifferentStores(): void
     {
         /**
          * @var \Magento\Bundle\Model\Product\OptionList $optionList

dev/tests/integration/testsuite/Magento/BundleImportExport/Model/Export/RowCustomizerTest.php

@@ -20,6 +20,9 @@ class RowCustomizerTest extends \PHPUnit\Framework\TestCase
      */
     private $objectManager;
 
+    /**
+     * @inheritdoc
+     */
     protected function setUp()
     {
         $this->objectManager = \Magento\TestFramework\Helper\Bootstrap::getObjectManager();
@@ -30,8 +33,10 @@ protected function setUp()
 
     /**
      * @magentoDataFixture Magento/Bundle/_files/product.php
+     *
+     * @return void
      */
-    public function testPrepareData()
+    public function testPrepareData(): void
     {
         $parsedAdditionalAttributes = 'text_attribute=!@#$%^&*()_+1234567890-=|\\:;"\'<,>.?/'
             . ',text_attribute2=,';
@@ -61,13 +66,15 @@ public function testPrepareData()
      * @magentoDataFixture Magento/Store/_files/second_store.php
      * @magentoDataFixture Magento/Bundle/_files/product.php
      * @magentoDbIsolation disabled
+     *
+     * @return void
      */
-    public function testPrepareDataWithDifferentStoreValues()
+    public function testPrepareDataWithDifferentStoreValues(): void
     {
         $storeCode = 'default';
         $expectedNames = [
             'name' => 'Bundle Product Items',
-            'name_' . $storeCode => 'Bundle Product Items_' . $storeCode
+            'name_' . $storeCode => 'Bundle Product Items_' . $storeCode,
         ];
         $parsedAdditionalAttributes = 'text_attribute=!@#$%^&*()_+1234567890-=|\\:;"\'<,>.?/'
             . ',text_attribute2=,';
@@ -94,14 +101,16 @@ public function testPrepareDataWithDifferentStoreValues()
         $bundleValues = array_map(
             function ($input) {
                 $data = explode('=', $input);
+
                 return [$data[0] => $data[1]];
             },
             explode(',', $result['bundle_values'])
         );
         $actualNames = [
             'name' => array_column($bundleValues, 'name')[0],
-            'name' . '_' . $store->getCode() => array_column($bundleValues, 'name' . '_' . $store->getCode())[0]
+            'name' . '_' . $store->getCode() => array_column($bundleValues, 'name' . '_' . $store->getCode())[0],
         ];
+
         self::assertSame($expectedNames, $actualNames);
     }
 }