Skip to content

Commit c8ed1e8

Browse files
committed
#21734 Error in JS validation rule
1 parent ce17220 commit c8ed1e8

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

app/code/Magento/Ui/view/base/web/js/lib/validation/rules.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -920,12 +920,12 @@ define([
920920
],
921921
'validate-per-page-value-list': [
922922
function (value) {
923-
var isValid = utils.isEmpty(value),
923+
var isValid = true,
924924
values = value.split(','),
925925
i;
926926

927-
if (isValid) {
928-
return true;
927+
if (utils.isEmpty(value)) {
928+
return isValid;
929929
}
930930

931931
for (i = 0; i < values.length; i++) {

lib/web/mage/validation.js

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1431,10 +1431,14 @@
14311431
],
14321432
'validate-per-page-value-list': [
14331433
function (v) {
1434-
var isValid = !$.mage.isEmpty(v),
1434+
var isValid = true,
14351435
values = v.split(','),
14361436
i;
14371437

1438+
if ($.mage.isEmpty(v)) {
1439+
return isValid;
1440+
}
1441+
14381442
for (i = 0; i < values.length; i++) {
14391443
if (!/^[0-9]+$/.test(values[i])) {
14401444
isValid = false;

0 commit comments

Comments
 (0)