MC-5421: Create test to check dependencies between modules in Declarative Schema

Author: fascinosum

dev/tests/static/testsuite/Magento/Test/Integrity/DeclarativeDependencyTest.php

@@ -22,6 +22,11 @@ class DeclarativeDependencyTest extends \PHPUnit\Framework\TestCase
      */
     private $dependencyProvider;
 
+    /**
+     * @var array
+     */
+    private $blacklistedDependencies = [];
+
     /**
      * Sets up data
      *
@@ -45,6 +50,14 @@ protected function setUp()
      */
     public function testUndeclaredDependencies()
     {
+        /** TODO: Remove this temporary solution after MC-15534 is closed */
+        $filePattern = __DIR__ . '/_files/dependency_test/blacklisted_dependencies_*.php';
+        $blacklistedDependencies = [];
+        foreach (glob($filePattern) as $fileName) {
+            $blacklistedDependencies = array_merge($blacklistedDependencies, require $fileName);
+        }
+        $this->blacklistedDependencies = $blacklistedDependencies;
+
         $invoker = new \Magento\Framework\App\Utility\AggregateInvoker($this);
         $invoker(
             /**
@@ -71,7 +84,9 @@ function ($file) {
                 $result = [];
                 foreach ($undeclaredDependency as $name => $modules) {
                     $modules = array_unique($modules);
-                    $result[] = $this->getErrorMessage($name) . "\n" . implode("\t\n", $modules);
+                    if ($this->filterBlacklistedDependencies($foundModuleName, $modules)) {
+                        $result[] = $this->getErrorMessage($name) . "\n" . implode("\t\n", $modules);
+                    }
                 }
                 if (count($result)) {
                     $this->fail(
@@ -83,6 +98,24 @@ function ($file) {
         );
     }
 
+    /**
+     * Filter blacklisted dependencies.
+     *
+     * @todo Remove this temporary solution after MC-15534 is closed
+     *
+     * @param string $moduleName
+     * @param array $dependencies
+     * @return array
+     */
+    private function filterBlacklistedDependencies(string $moduleName, array $dependencies): array
+    {
+        if (!empty($this->blacklistedDependencies[$moduleName])) {
+            $dependencies = array_diff($dependencies, $this->blacklistedDependencies[$moduleName]);
+        }
+
+        return $dependencies;
+    }
+
     /**
      * Convert file list to data provider structure.
      *

dev/tests/static/testsuite/Magento/Test/Integrity/_files/dependency_test/blacklisted_dependencies_ce.php

@@ -0,0 +1,9 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+declare(strict_types=1);
+return [
+    "Magento\InventorySales" => ["Magento\Inventory"],
+];