MAGETWO-31559: [TD] Removing NominalItems usage

-- unit tests (open access to method authorize)

Author: Pavlo Cherniavskyi

app/code/Magento/Sales/Model/Order/Payment.php

@@ -377,7 +377,7 @@ protected function processAction($action, \Magento\Sales\Model\Order $order)
                 $this->_order($baseTotalDue);
                 break;
             case \Magento\Payment\Model\Method\AbstractMethod::ACTION_AUTHORIZE:
-                $this->_authorize(true, $baseTotalDue);
+                $this->authorize(true, $baseTotalDue);
                 // base amount will be set inside
                 $this->setAmountAuthorized($totalDue);
                 break;
@@ -571,7 +571,7 @@ public function registerCaptureNotification($amount, $skipFraudDetection = false
      */
     public function registerAuthorizationNotification($amount)
     {
-        return $this->_isTransactionExists() ? $this : $this->_authorize(false, $amount);
+        return $this->_isTransactionExists() ? $this : $this->authorize(false, $amount);
     }
 
     /**
@@ -1125,9 +1125,10 @@ protected function _order($amount)
      *
      * @param bool $isOnline
      * @param float $amount
+     *
      * @return $this
      */
-    protected function _authorize($isOnline, $amount)
+    public function authorize($isOnline, $amount)
     {
         // check for authorization amount to be equal to grand total
         $this->setShouldCloseParentTransaction(false);
@@ -1181,18 +1182,6 @@ protected function _authorize($isOnline, $amount)
         return $this;
     }
 
-    /**
-     * Public access to _authorize method
-     *
-     * @param bool $isOnline
-     * @param float $amount
-     * @return $this
-     */
-    public function authorize($isOnline, $amount)
-    {
-        return $this->_authorize($isOnline, $amount);
-    }
-
     /**
      * Void payment either online or offline (process void notification)
      * NOTE: that in some cases authorization can be voided after a capture. In such case it makes sense to use

dev/tests/static/testsuite/Magento/Test/Legacy/_files/obsolete_methods.php

@@ -1652,6 +1652,7 @@
     ['_isDataChanged', 'Magento\Catalog\Model\Product'],
     ['getVisibleOnFrontStates', 'Magento\Sales\Model\Order\Config', 'getVisibleOnFrontStatuses'],
     ['getInvisibleOnFrontStates', 'Magento\Sales\Model\Order\Config', 'getInvisibleOnFrontStatuses'],
+    ['_authorize', 'Magento\Sales\Model\Order\Payment'],
     ['_shouldBeConverted', 'Magento\Sales\Model\Resource\AbstractResource'],
     ['_beforeSave', 'Magento\Sales\Model\Resource\AbstractResource'],
     ['_afterSave', 'Magento\Sales\Model\Resource\AbstractResource'],