Skip to content

Commit c8abbb9

Browse files
Fixed static test failures
1 parent 863bae7 commit c8abbb9

File tree

2 files changed

+15
-8
lines changed

2 files changed

+15
-8
lines changed

lib/internal/Magento/Framework/Message/Manager.php

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,15 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2017 Adobe
4+
* All Rights Reserved.
55
*/
66
namespace Magento\Framework\Message;
77

88
use Magento\Framework\Event;
99
use Psr\Log\LoggerInterface;
1010
use Magento\Framework\App\ObjectManager;
1111
use Magento\Framework\Debug;
12+
use Magento\Framework\Message\ExceptionMessageLookupFactory;
1213

1314
/**
1415
* Message manager model
@@ -21,7 +22,7 @@ class Manager implements ManagerInterface
2122
/**
2223
* Default message group
2324
*/
24-
const DEFAULT_GROUP = 'default';
25+
protected const DEFAULT_GROUP = 'default';
2526

2627
/**
2728
* @var Session
@@ -63,6 +64,11 @@ class Manager implements ManagerInterface
6364
*/
6465
private $exceptionMessageFactory;
6566

67+
/**
68+
* @var ExceptionMessageLookupFactory
69+
*/
70+
private $exceptionMessageLookupFactory;
71+
6672
/**
6773
* @param Session $session
6874
* @param Factory $messageFactory
@@ -71,6 +77,7 @@ class Manager implements ManagerInterface
7177
* @param LoggerInterface $logger
7278
* @param string $defaultGroup
7379
* @param ExceptionMessageFactoryInterface|null $exceptionMessageFactory
80+
* @param ExceptionMessageLookupFactory|null $exceptionMessageLookupFactory
7481
*/
7582
public function __construct(
7683
Session $session,
@@ -79,16 +86,16 @@ public function __construct(
7986
Event\ManagerInterface $eventManager,
8087
LoggerInterface $logger,
8188
$defaultGroup = self::DEFAULT_GROUP,
82-
ExceptionMessageFactoryInterface $exceptionMessageFactory = null
89+
ExceptionMessageFactoryInterface $exceptionMessageFactory = null,
90+
ExceptionMessageLookupFactory $exceptionMessageLookupFactory = null
8391
) {
8492
$this->session = $session;
8593
$this->messageFactory = $messageFactory;
8694
$this->messagesFactory = $messagesFactory;
8795
$this->eventManager = $eventManager;
8896
$this->logger = $logger;
8997
$this->defaultGroup = $defaultGroup;
90-
$this->exceptionMessageFactory = $exceptionMessageFactory ?: ObjectManager::getInstance()
91-
->get(ExceptionMessageLookupFactory::class);
98+
$this->exceptionMessageFactory = $exceptionMessageFactory ?: $exceptionMessageLookupFactory;
9299
}
93100

94101
/**

lib/internal/Magento/Framework/Message/ManagerInterface.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?php
22
/**
3-
* Copyright © Magento, Inc. All rights reserved.
4-
* See COPYING.txt for license details.
3+
* Copyright 2017 Adobe
4+
* All Rights Reserved.
55
*/
66
namespace Magento\Framework\Message;
77

0 commit comments

Comments
 (0)