MC-18509: Update resolvers to implement the schema changes

- fix review comments

Author: Prabhu Ram

app/code/Magento/CatalogGraphQl/Model/Resolver/Product/MediaGallery.php

@@ -49,14 +49,12 @@ public function resolve(
         $product = $value['model'];
 
         $mediaGalleryEntries = [];
-        if (!empty($product->getMediaGalleryEntries())) {
-            foreach ($product->getMediaGalleryEntries() as $key => $entry) {
-                $mediaGalleryEntries[$key] = $entry->getData();
-                $mediaGalleryEntries[$key]['model'] = $product;
-                if ($entry->getExtensionAttributes() && $entry->getExtensionAttributes()->getVideoContent()) {
-                    $mediaGalleryEntries[$key]['video_content']
-                        = $entry->getExtensionAttributes()->getVideoContent()->getData();
-                }
+        foreach ($product->getMediaGalleryEntries() ?? [] as $key => $entry) {
+            $mediaGalleryEntries[$key] = $entry->getData();
+            $mediaGalleryEntries[$key]['model'] = $product;
+            if ($entry->getExtensionAttributes() && $entry->getExtensionAttributes()->getVideoContent()) {
+                $mediaGalleryEntries[$key]['video_content']
+                    = $entry->getExtensionAttributes()->getVideoContent()->getData();
             }
         }
         return $mediaGalleryEntries;

app/code/Magento/CatalogGraphQl/Model/Resolver/Product/MediaGallery/Label.php

@@ -13,9 +13,10 @@
 use Magento\Framework\GraphQl\Config\Element\Field;
 use Magento\Framework\GraphQl\Query\ResolverInterface;
 use Magento\Framework\GraphQl\Schema\Type\ResolveInfo;
+use Magento\Store\Model\Store;
 
 /**
- * Returns media label
+ * Return media label
  */
 class Label implements ResolverInterface
 {
@@ -55,13 +56,15 @@ public function resolve(
         /** @var Product $product */
         $product = $value['model'];
         $productId = (int)$product->getEntityId();
-        $storeId = (int)$context->getExtensionAttributes()->getStore()->getId();
+        /** @var Store $store */
+        $store = $context->getExtensionAttributes()->getStore();
+        $storeId = (int)$store->getId();
         if (!isset($value['image_type'])) {
             return $this->getAttributeValue($productId, 'name', $storeId);
         }
         $imageType = $value['image_type'];
         $imageLabel = $this->getAttributeValue($productId, $imageType . '_label', $storeId);
-        if (null === $imageLabel) {
+        if ($imageLabel == null) {
             $imageLabel = $this->getAttributeValue($productId, 'name', $storeId);
         }
 

app/code/Magento/CatalogGraphQl/Model/Resolver/Product/ProductVideo.php

@@ -185,9 +185,9 @@ type CustomizableFileValue @doc(description: "CustomizableFileValue defines the
     image_size_y: Int @doc(description: "The maximum height of an image.")
 }
 
-interface MediaGalleryInterface @typeResolver(class: "Magento\\CatalogGraphQl\\Model\\MediaGalleryTypeResolver") {
-    url: String @resolver(class: "Magento\\CatalogGraphQl\\Model\\Resolver\\Product\\MediaGallery\\Url")
-    label: String @resolver(class: "Magento\\CatalogGraphQl\\Model\\Resolver\\Product\\MediaGallery\\Label")
+interface MediaGalleryInterface @doc(description: "Contains basic information about a product image or video.") @typeResolver(class: "Magento\\CatalogGraphQl\\Model\\MediaGalleryTypeResolver") {
+    url: String @doc(description: "The URL of the product image or video.") @resolver(class: "Magento\\CatalogGraphQl\\Model\\Resolver\\Product\\MediaGallery\\Url")
+    label: String @doc(description: "The label of the product image or video.") @resolver(class: "Magento\\CatalogGraphQl\\Model\\Resolver\\Product\\MediaGallery\\Label")
 }
 
 type ProductImage implements MediaGalleryInterface @doc(description: "Product image information. Contains the image URL and label.") {
@@ -419,5 +419,5 @@ type StoreConfig @doc(description: "The type contains information about a store
 }
 
 type ProductVideo @doc(description: "Contains information about a product video.") implements MediaGalleryInterface {
-    video_content: ProductMediaGalleryEntriesVideoContent @resolver(class: "Magento\\CatalogGraphQl\\Model\\Resolver\\Product\\ProductVideo")
+    video_content: ProductMediaGalleryEntriesVideoContent @doc(description: "Contains a ProductMediaGalleryEntriesVideoContent object.")
 }